Skip to content

fix(language-service): initialize static reflector correctly - #15769

Merged
alxhub merged 1 commit into
angular:masterfrom
chuckjaz:issue61
Apr 4, 2017
Merged

alxhub merged 1 commit into
angular:masterfrom
chuckjaz:issue61

Conversation

@chuckjaz

@chuckjaz chuckjaz commented Apr 4, 2017

Copy link
Copy Markdown
Contributor

Fixes #15768

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix

What is the current behavior? (You can also link to an open issue here)

#15768

What is the new behavior?

Using else no longer causes the language service to crash.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"false; else loading" ? (keep it as simple as it the test needs)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a regression I want it to match the original report.

@chuckjaz chuckjaz added the action: merge The PR is ready for merge by the caretaker label Apr 4, 2017
@alxhub
alxhub merged commit fe0d02f into angular:master Apr 4, 2017
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

language service: using else in an ngIf can cause the language service to crash

4 participants