Skip to content

fix(compiler-cli): update the tsc-wrapped dependency version - #15226

Merged
chuckjaz merged 1 commit into
angular:masterfrom
chuckjaz:fix-compiler-cli-dep
Mar 17, 2017
Merged

chuckjaz merged 1 commit into
angular:masterfrom
chuckjaz:fix-compiler-cli-dep

Conversation

@chuckjaz

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix

What is the current behavior? (You can also link to an open issue here)

@angular/compiler-cli references an outdated version of @angular/tsc-wrapped

What is the new behavior?

@angular/compiler-cli references the current version of @angular/tsc-wrapped

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

},
"dependencies": {
"@angular/tsc-wrapped": "4.0.0-rc.2",
"@angular/tsc-wrapped": "4.0.0-rc.4",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it easier to use "0.0.0-PLACEHOLDER" so it will be incremented automatically?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it would and we should move to that. Unfortunately, we only release a tsc-wrapped when it was modified (e.g. there was no @angular/tsc-wrapped@4.0.0-rc.3. We would need to change that too if we moved to using PLACEHOLDER.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chuckjaz we should always release tsc-wrapped, even if there were no modifications. it's just safer that way.

@jasonaden and I talked about it a few days ago and we even filed #14719 but given all the other things, we considered it to be a low priority item - something we could do after 4.0.0 is out.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified the release instructions to make it clear releasing a new @angular/tsc-wrapped is not optional.

@chuckjaz
chuckjaz merged commit 7fb4528 into angular:master Mar 17, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants