[4.x only] feat(compiler): should only inject services annotated with @Injectable - #14931

it can make a huge impact on existing apps. I think it needs deprecation phase and warning message.

@laco0416 I agree it will have a huge impact but what exactly is it deprecating? and it does have a warning message: syntaxError('${stringifyType(identifier)} must be annotated with @Injectable'));

I expect it emits only warning messages without any effects on application behaviors.

@laco0416

it can make a huge impact on existing apps

don't think so. it's already recommended in the style guide to always use Injectable.

First, the style guide says only "Use @Injectable() instead of @Inject()".

https://angular.io/docs/ts/latest/guide/style-guide.html#!#07-04

Do use the @Injectable class decorator instead of the @Inject parameter decorator when using types as tokens for the dependencies of a service.

And as you say, the recommendation is existing at https://angular.io/docs/ts/latest/guide/dependency-injection.html#!#injectable . but this is just a suggestion. not a warning.

Angular hasn't warned Injectable-less services anywhere yet. It's not ready to be broken.

Only security fixes go to 4.x

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}