fix(compiler): support interface types in injectable constuctors#14894
Merged
chuckjaz merged 1 commit intoangular:masterfrom Mar 15, 2017
Merged
fix(compiler): support interface types in injectable constuctors#14894chuckjaz merged 1 commit intoangular:masterfrom
chuckjaz merged 1 commit intoangular:masterfrom
Conversation
tbosch
reviewed
Mar 7, 2017
Contributor
There was a problem hiding this comment.
Maybe add a test for when the interface is in a different file than the usage.
tbosch
approved these changes
Mar 7, 2017
tbosch
approved these changes
Mar 7, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12631
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
ngcwill generate an error when an@Injectableclass uses an interface as a parameter with an@Injectparameter.What is the new behavior?
The type of the parameter is ignored and the instance implied by the token is injected into the class.
Does this PR introduce a breaking change? (check one with "x")