Skip to content

fix(core): clean up TestabilityRegistry on platform destroy to avoid memory leaks #14819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DzmitryShylovich wants to merge 1 commit into from
Closed

fix(core): clean up TestabilityRegistry on platform destroy to avoid memory leaks #14819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/@angular/core/src/application_ref.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,7 @@ export class PlatformRef_ extends PlatformRef {
}
this._modules.slice().forEach(module => module.destroy());
this._destroyListeners.forEach(listener => listener());
this._injector.get(TestabilityRegistry).destroy();
this._destroyed = true;
}

Expand Down
8 changes: 8 additions & 0 deletions modules/@angular/core/src/testability/testability.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,11 @@ export class TestabilityRegistry {
findTestabilityInTree(elem: Node, findInAncestors: boolean = true): Testability {
return _testabilityGetter.findTestabilityInTree(this, elem, findInAncestors);
}

destroy(): void {
this._applications.clear();
_testabilityGetter.onDestroy();
}
}

/**
Expand All @@ -158,6 +163,7 @@ export interface GetTestability {
addToWindow(registry: TestabilityRegistry): void;
findTestabilityInTree(registry: TestabilityRegistry, elem: any, findInAncestors: boolean):
Testability;
onDestroy(): void;
}

class _NoopGetTestability implements GetTestability {
Expand All @@ -166,6 +172,8 @@ class _NoopGetTestability implements GetTestability {
Testability {
return null;
}

onDestroy(): void {}
}

/**
Expand Down
7 changes: 7 additions & 0 deletions modules/@angular/platform-browser/src/browser/testability.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,11 @@ export class BrowserGetTestability implements GetTestability {
}
return this.findTestabilityInTree(registry, getDOM().parentElement(elem), true);
}

onDestroy(): void {
delete global.getAngularTestability;
delete global.getAllAngularTestabilities;
delete global.getAllAngularRootElements;
delete global.frameworkStabilizers;
}
}
1 change: 1 addition & 0 deletions tools/public_api_guard/core/typings/core.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,6 +966,7 @@ export declare class Testability implements PublicTestability {
/** @experimental */
export declare class TestabilityRegistry {
constructor();
destroy(): void;
findTestabilityInTree(elem: Node, findInAncestors?: boolean): Testability;
getAllRootElements(): any[];
getAllTestabilities(): Testability[];
Expand Down