Repository navigation
fix(common): do not reference deprecated classes in providers - #14523
Merged
Merged
Conversation
Contributor
|
Do we need to keep |
petebacondarwin
added a commit
to angular/dgeni-packages
that referenced
this pull request
Feb 16, 2017
When aliasing a class one must create two declarations for a symbol:
```
class OriginalClass {}
const AliasedClass = OriginalClass;
type AliasedClass = OriginalClass;
```
Previously we were looking for the type on the value definition (i.e.
the `const`), and not finding it. Now if the type is not found on the
value definition then we search the other declarations for the first
to have a `type` property.
Related to angular/angular#14523
vicb
reviewed
Feb 17, 2017
Contributor
There was a problem hiding this comment.
const testDirective = fixture.debugElement.query(By.directive(TestDirective));
Why not inject both in the td ?
Contributor
Author
There was a problem hiding this comment.
Also query seems to return the DebugElement and not TestDirective
3 tasks done
…r#14523) References to `NgFor` are now an alias for `NgForOf` instead of a derived class. Fixes angular#14521
IgorMinar
approved these changes
Feb 24, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…r#14523) (angular#14523) References to `NgFor` are now an alias for `NgForOf` instead of a derived class. Fixes angular#14521
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…r#14523) (angular#14523) References to `NgFor` are now an alias for `NgForOf` instead of a derived class. Fixes angular#14521
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References to
NgForare now an alias forNgForOfinstead of a derived class.Fixes #14521
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
The compiler will generate references to the deprecated class
NgForbecause theNgForis reference in the provider forNgForOf<T>.What is the new behavior?
The compiler no longer generates references to the deprecated
NgForclass.Does this PR introduce a breaking change? (check one with "x")