Repository navigation
Conversation
IgorMinar
self-requested a review
February 7, 2017 05:59
IgorMinar
suggested changes
Feb 7, 2017
IgorMinar
left a comment
IgorMinar
left a comment
Contributor
There was a problem hiding this comment.
the diff of this PR looks odd
I would not expect all the dgeni and nunjucks related packages in there.
have you pulled the most recent master and reinstalled your node modules before installing the ts-api-guardian?
the shrinkwrap update process is documented here: https://github.com/angular/angular/blob/master/npm-shrinkwrap.readme.md
chuckjaz
force-pushed
the
update-api-guardian
branch
from
February 7, 2017 18:12
90dd190 to
1114d3b
Compare
IgorMinar
approved these changes
Feb 7, 2017
Contributor
|
Folding this into the TS 2.1 upgrade PR |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Angular used 0.1.4 of
ts-api-guardianwhich used1.7.3of TypeScript. Using features introduced after1.7.3would produce inconsistent and incomplete guardian files.What is the new behavior?
Angular now uses 0.2.0 of
ts-api-guardianwhich uses2.0.10of TypeScript. This allows correctly guarding apis that use TypeScript 2.0 features.Does this PR introduce a breaking change? (check one with "x")