Repository navigation
ci: update typings test to use standard typings - #14156
Merged
Merged
Conversation
chuckjaz
force-pushed
the
typings-test
branch
from
January 27, 2017 22:31
1913295 to
c851e39
Compare
Contributor
|
I have #14149 out also, conflicts with this (in a simple way) but we can see who merges first :) We need users to change their tsconfig for this. Should we document a breaking change "you need to use stdlibs" or will that just be an obvious part of the TS 2.1 upgrade? Change LGTM |
Contributor
Author
|
This change doesn't require use to update there tsconfig.json files it but my next change, adding |
mhevery
self-requested a review
January 28, 2017 00:16
mhevery
approved these changes
Jan 28, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
The typings test validates against
@types/es6-collectionsand@types/es6-promises. Standard versions of these typings are part of 2.0.What is the new behavior?
Changed to use the TypeScript definition of ES6 types. Added
Iterable.Does this PR introduce a breaking change? (check one with "x")