Skip to content

fix(common): DatePipe doesn't throw for NaN #14117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DzmitryShylovich wants to merge 1 commit into from
Closed

fix(common): DatePipe doesn't throw for NaN #14117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/@angular/common/src/pipes/date_pipe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export class DatePipe implements PipeTransform {
transform(value: any, pattern: string = 'mediumDate'): string {
let date: Date;

if (isBlank(value)) return null;
if (isBlank(value) || value !== value) return null;

if (typeof value === 'string') {
value = value.trim();
Expand Down
2 changes: 2 additions & 0 deletions modules/@angular/common/test/pipes/date_pipe_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ export function main() {

it('should return null for empty string', () => expect(pipe.transform('')).toEqual(null));

it('should return null for NaN', () => expect(pipe.transform(Number.NaN)).toEqual(null));

it('should support ISO string without time',
() => { expect(() => pipe.transform(isoStringWithoutTime)).not.toThrow(); });

Expand Down