Skip to content

Init angular.io#14098

Closed
IgorMinar wants to merge 4 commits into
angular:masterfrom
IgorMinar:init-angular.io
Closed

Init angular.io#14098
IgorMinar wants to merge 4 commits into
angular:masterfrom
IgorMinar:init-angular.io

Conversation

@IgorMinar

Copy link
Copy Markdown
Contributor

No description provided.

@IgorMinar IgorMinar requested a review from mhevery January 25, 2017 10:44
@IgorMinar IgorMinar force-pushed the init-angular.io branch 3 times, most recently from 8cf01d6 to 0d69d8c Compare January 25, 2017 17:40
@gkalpak gkalpak mentioned this pull request Jan 25, 2017
7 tasks
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker pr_state: LGTM labels Jan 25, 2017
@mhevery

mhevery commented Jan 25, 2017

Copy link
Copy Markdown
Contributor

LGTM

Approved with PullApprove

@IgorMinar

Copy link
Copy Markdown
Contributor Author

@alxhub do you know why the commit message validation tests are failing? I haven't touched that stuff. has it been failing for a while? It was green when my PR was merged.

@gkalpak

gkalpak commented Jan 25, 2017

Copy link
Copy Markdown
Member

@IgorMinar, I thinkknow it fails because you added the aio commit message scope, so the expected error messages (which list the valid scopes) have changed.

@IgorMinar

Copy link
Copy Markdown
Contributor Author

@gkalpak ahh.. right! silly me. I'll fix it.

@vicb vicb closed this in 4106d18 Jan 26, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants