Skip to content

fix(common): add PopStateEvent interface - #13400

Closed
DzmitryShylovich wants to merge 1 commit into
angular:masterfrom
DzmitryShylovich:gh/13378
Closed

DzmitryShylovich wants to merge 1 commit into
angular:masterfrom
DzmitryShylovich:gh/13378

Conversation

@DzmitryShylovich

Copy link
Copy Markdown
Contributor

Closes #13378

@vicb vicb added area: common Issues related to APIs in the @angular/common package feature Label used to distinguish feature request from other issues labels Dec 12, 2016
@mhevery

mhevery commented Jan 28, 2017

Copy link
Copy Markdown
Contributor

Tests please

@DzmitryShylovich

Copy link
Copy Markdown
Contributor Author

@mhevery I just added an interface instead of any. Not sure how I can test it.

@mhevery

mhevery commented Jan 31, 2017

Copy link
Copy Markdown
Contributor

I see, sounds good.

@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Jan 31, 2017
@mhevery mhevery closed this in fe44118 Jan 31, 2017
mhevery pushed a commit that referenced this pull request Feb 3, 2017
mhevery pushed a commit to mhevery/angular that referenced this pull request Feb 3, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package cla: yes feature Label used to distinguish feature request from other issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

location subscribe returns an object instead of "real" interface

4 participants