Skip to content

docs(core): update OnDestroy description - #13369

Merged
vicb merged 1 commit into
angular:masterfrom
DzmitryShylovich:gh/11228
Dec 13, 2016
Merged

vicb merged 1 commit into
angular:masterfrom
DzmitryShylovich:gh/11228

Conversation

@DzmitryShylovich

Copy link
Copy Markdown
Contributor

Closes #11228

@vicb vicb added area: core Issues related to the framework runtime comp: docs labels Dec 10, 2016
@vicb

vicb commented Dec 10, 2016

Copy link
Copy Markdown
Contributor

@tbosch could you please confirm that ngOnDestroy is intended to be called for any injected service ?

@vicb

vicb commented Dec 12, 2016

Copy link
Copy Markdown
Contributor

I discussed with @tbosch and it is indeed intended.

@vicb vicb added action: merge The PR is ready for merge by the caretaker pr_state: LGTM labels Dec 12, 2016
@vicb
vicb merged commit 1d0ed6f into angular:master Dec 13, 2016
vicb pushed a commit that referenced this pull request Dec 15, 2016
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

destructor option for service providers

3 participants