Upgrade to TypeScript 2.1 - #13294

We do test the .d.ts files we publish that they work with TS 1.8 https://github.com/angular/angular/blob/master/tools/typings-test/test.sh#L22 But I think we are missing a test that our JS code executes correctly with TS 1.8 as a runtime dep On Thu, Dec 8, 2016 at 10:41 AM Cotton Hou <notifications@github.com> wrote: *@imcotton* commented on this pull request. ------------------------------ In tools/@angular/tsc-wrapped/src/collector.ts <#13294>:

import {ClassMetadata, ConstructorMetadata, FunctionMetadata, MemberMetadata, MetadataEntry, MetadataError, MetadataMap, MetadataObject, MetadataSymbolicBinaryExpression, MetadataSymbolicCallExpression, MetadataSymbolicExpression, MetadataSymbolicIfExpression, MetadataSymbolicIndexExpression, MetadataSymbolicPrefixExpression, MetadataSymbolicReferenceExpression, MetadataSymbolicSelectExpression, MetadataSymbolicSpreadExpression, MetadataValue, MethodMetadata, ModuleExportMetadata, ModuleMetadata, VERSION, isClassMetadata, isConstructorMetadata, isFunctionMetadata, isMetadataError, isMetadataGlobalReferenceExpression, isMetadataSymbolicExpression, isMetadataSymbolicReferenceExpression, isMetadataSymbolicSelectExpression, isMethodMetadata} from './schema'; import {Symbols} from './symbols'; +// ModifierFlags introduced in TS 2.1 +// TypeScript prior to 2.1 uses the NodeFlags to store modifiers +const isStatic = !!ts.ModifierFlags ? Oh I see, it's devDependencies in package.json, so there could be a test scenario to simulates TS v1.8 as well? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#13294>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAC5I5YUYomlSN8NDq-PmvhpVfdNKEWVks5rGE9XgaJpZM4LHQfe> .

This is blocked on getting angular/tsickle updated to TS 2.1 which is somewhat harder.