Skip to content

refactor(tsc-wrapped): organize NodeFlags checker - #13081

Closed
imcotton wants to merge 1 commit into
angular:masterfrom
imcotton:tsc-wrapped-node-flags
Closed

refactor(tsc-wrapped): organize NodeFlags checker#13081
imcotton wants to merge 1 commit into
angular:masterfrom
imcotton:tsc-wrapped-node-flags

Conversation

@imcotton

@imcotton imcotton commented Nov 25, 2016

Copy link
Copy Markdown
Contributor

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

Other information:

To put potential changes into single place.

@imcotton
imcotton force-pushed the tsc-wrapped-node-flags branch from 0e592cd to 0d516a6 Compare November 25, 2016 02:33
@imcotton imcotton mentioned this pull request Nov 25, 2016
Closed
alexeagle
alexeagle reviewed Dec 7, 2016
View reviewed changes

@alexeagle alexeagle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I talked to Chuck, we'll do this a slightly different way. I just started a PR to do the whole TS 2.1 upgrade including fixes in the metadata collector.

@imcotton

imcotton commented Dec 8, 2016

Copy link
Copy Markdown
Contributor Author

Close in favor of #13294

@imcotton imcotton closed this Dec 8, 2016
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 10, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@alexeagle alexeagle alexeagle left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@imcotton @alexeagle @googlebot