Skip to content

fix(compiler-cli): don't unnecessarily throw on StaticSymbols #12158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbosch merged 1 commit into from
Oct 11, 2016
Merged

fix(compiler-cli): don't unnecessarily throw on StaticSymbols #12158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions modules/@angular/compiler-cli/src/static_reflector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,9 @@ export class StaticReflector implements ReflectorReader {
}
return result;
}
if (expression instanceof StaticSymbol) {
return expression;
}
if (expression) {

@chuckjaz chuckjaz Oct 11, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this to be a separate commit. Just squash them.

@steve8708 steve8708 Oct 11, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chuckjaz squashed 👍

if (expression['__symbolic']) {
let staticSymbol: StaticSymbol;
Expand Down
5 changes: 5 additions & 0 deletions modules/@angular/compiler-cli/test/static_reflector_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,11 @@ describe('StaticReflector', () => {
expect(simplify(noContext, 'some value')).toBe('some value');
});

it('should simplify a static symbol into itself', () => {
const staticSymbol = new StaticSymbol('', '');
expect(simplify(noContext, staticSymbol)).toBe(staticSymbol);
});

it('should simplify an array into a copy of the array', () => {
expect(simplify(noContext, [1, 2, 3])).toEqual([1, 2, 3]);
});
Expand Down