Repository navigation
test: reactivate the remaining disabled tests in Edge - #11188
Merged
Merged
Conversation
marclaval
added
the
action: review
IgorMinar
added
pr_state: LGTM
action: merge
AlmogShaul
pushed a commit
to AlmogShaul/angular
that referenced
this pull request
Sep 8, 2016
Fixes angular#4756 style(dom_renderer): use const (angular#11229) build: update the symlinks scripts for Windows to new packaging (angular#11192) docs(CHANGELOG): fix provider syntax (angular#11258) fixes angular#11256 fix typo (angular#11265) meesage => message refactor(EventManager): remove ListWrapper (angular#11363) fix(compiler): correctly type event handler proxy functions fix(compiler): error when `NgModule.bootstrap` contains `undefined` or `null` fix(lazy-loading): fix an issue with webpack and lazy loader. (angular#11387) The issue was introduced in PR#11049. feat(benchmarks): add targetable benchmarks back refactor(benchmarks): align tree benchmark with largetable benchmark - add ng2_switch benchmark to track `ngFor` over `ngSwitch` - measure create only, createDestroy and update - simplify the created dom - always add a style binding ci: update SauceLabs badge when running CI on master (angular#11352) build(test.sh): clear dist directory when the script starts This is to prevent stale files causing the tests to fail when we run them locally after checking out a new revision. build: remove obsolete presubmit.sh script test: cleanup playground/src/bootstrap.ts file docs: misc fixes. docs(common_module): Fix macro format docs(number_pipe): Add missing period sign docs(date_pipe): Fix suffix consistency docs(date_pipe): Fix missing quote docs(number_pipe): Fix incorrect article Looks like the word "Polyfill" does not start with a vowel pronunciation. docs(location_strategy): Fix code format Add missing \`\`\` at start. docs(i18n_plural_pipe): Fix code format docs(location): Add missing period sign refactor(ngSwitch): fix typo on parameter docs(di): Add missing quote docs(compiler): Fix typo docs(compiler): Add missing period sign docs(directives): Fix description for styles parameter docs(location_strategy): Add code language Revert for misunderstanding. Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe test: reactivate the remaining disabled tests in Edge (angular#11188) Fixes angular#4756 style(dom_renderer): use const (angular#11229) build: update the symlinks scripts for Windows to new packaging (angular#11192) docs(CHANGELOG): fix provider syntax (angular#11258) fixes angular#11256 fix typo (angular#11265) meesage => message refactor(EventManager): remove ListWrapper (angular#11363) fix(compiler): correctly type event handler proxy functions fix(compiler): error when `NgModule.bootstrap` contains `undefined` or `null` fix(lazy-loading): fix an issue with webpack and lazy loader. (angular#11387) The issue was introduced in PR#11049. feat(benchmarks): add targetable benchmarks back refactor(benchmarks): align tree benchmark with largetable benchmark - add ng2_switch benchmark to track `ngFor` over `ngSwitch` - measure create only, createDestroy and update - simplify the created dom - always add a style binding ci: update SauceLabs badge when running CI on master (angular#11352) build(test.sh): clear dist directory when the script starts This is to prevent stale files causing the tests to fail when we run them locally after checking out a new revision. build: remove obsolete presubmit.sh script test: cleanup playground/src/bootstrap.ts file docs: misc fixes. docs(common_module): Fix macro format docs(number_pipe): Add missing period sign docs(date_pipe): Fix suffix consistency docs(date_pipe): Fix missing quote docs(number_pipe): Fix incorrect article Looks like the word "Polyfill" does not start with a vowel pronunciation. docs(location_strategy): Fix code format Add missing \`\`\` at start. docs(i18n_plural_pipe): Fix code format docs(location): Add missing period sign refactor(ngSwitch): fix typo on parameter docs(di): Add missing quote docs(compiler): Fix typo docs(compiler): Add missing period sign docs(directives): Fix description for styles parameter docs(location_strategy): Add code language Revert for misunderstanding.
AlmogShaul
added a commit
to AlmogShaul/angular
that referenced
this pull request
Sep 8, 2016
Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe test: reactivate the remaining disabled tests in Edge (angular#11188) Fixes angular#4756 style(dom_renderer): use const (angular#11229) build: update the symlinks scripts for Windows to new packaging (angular#11192) docs(CHANGELOG): fix provider syntax (angular#11258) fixes angular#11256 fix typo (angular#11265) meesage => message refactor(EventManager): remove ListWrapper (angular#11363) fix(compiler): correctly type event handler proxy functions fix(compiler): error when `NgModule.bootstrap` contains `undefined` or `null` fix(lazy-loading): fix an issue with webpack and lazy loader. (angular#11387) The issue was introduced in PR#11049. feat(benchmarks): add targetable benchmarks back refactor(benchmarks): align tree benchmark with largetable benchmark - add ng2_switch benchmark to track `ngFor` over `ngSwitch` - measure create only, createDestroy and update - simplify the created dom - always add a style binding ci: update SauceLabs badge when running CI on master (angular#11352) build(test.sh): clear dist directory when the script starts This is to prevent stale files causing the tests to fail when we run them locally after checking out a new revision. build: remove obsolete presubmit.sh script test: cleanup playground/src/bootstrap.ts file docs: misc fixes. docs(common_module): Fix macro format docs(number_pipe): Add missing period sign docs(date_pipe): Fix suffix consistency docs(date_pipe): Fix missing quote docs(number_pipe): Fix incorrect article Looks like the word "Polyfill" does not start with a vowel pronunciation. docs(location_strategy): Fix code format Add missing \`\`\` at start. docs(i18n_plural_pipe): Fix code format docs(location): Add missing period sign refactor(ngSwitch): fix typo on parameter docs(di): Add missing quote docs(compiler): Fix typo docs(compiler): Add missing period sign docs(directives): Fix description for styles parameter docs(location_strategy): Add code language Revert for misunderstanding. Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe Proper case pipe test: reactivate the remaining disabled tests in Edge (angular#11188) Fixes angular#4756 style(dom_renderer): use const (angular#11229) build: update the symlinks scripts for Windows to new packaging (angular#11192) docs(CHANGELOG): fix provider syntax (angular#11258) fixes angular#11256 fix typo (angular#11265) meesage => message refactor(EventManager): remove ListWrapper (angular#11363) fix(compiler): correctly type event handler proxy functions fix(compiler): error when `NgModule.bootstrap` contains `undefined` or `null` fix(lazy-loading): fix an issue with webpack and lazy loader. (angular#11387) The issue was introduced in PR#11049. feat(benchmarks): add targetable benchmarks back refactor(benchmarks): align tree benchmark with largetable benchmark - add ng2_switch benchmark to track `ngFor` over `ngSwitch` - measure create only, createDestroy and update - simplify the created dom - always add a style binding ci: update SauceLabs badge when running CI on master (angular#11352) build(test.sh): clear dist directory when the script starts This is to prevent stale files causing the tests to fail when we run them locally after checking out a new revision. build: remove obsolete presubmit.sh script test: cleanup playground/src/bootstrap.ts file docs: misc fixes. docs(common_module): Fix macro format docs(number_pipe): Add missing period sign docs(date_pipe): Fix suffix consistency docs(date_pipe): Fix missing quote docs(number_pipe): Fix incorrect article Looks like the word "Polyfill" does not start with a vowel pronunciation. docs(location_strategy): Fix code format Add missing \`\`\` at start. docs(i18n_plural_pipe): Fix code format docs(location): Add missing period sign refactor(ngSwitch): fix typo on parameter docs(di): Add missing quote docs(compiler): Fix typo docs(compiler): Add missing period sign docs(directives): Fix description for styles parameter docs(location_strategy): Add code language Revert for misunderstanding.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4756
These 2 unit tests now pass successfully when running the campaign in the latest stable Edge (13.10586).
With this PR, there are no more disabled tests in Edge.
Note: the changes in
router.tsare for a formatting issue that made it to master