Skip to content

feat(linker): Allow configurable module prefixes and suffixes. - #11049

Merged
vicb merged 1 commit into
angular:masterfrom
alxhub:system-module-prefix
Aug 24, 2016
Merged

vicb merged 1 commit into
angular:masterfrom
alxhub:system-module-prefix

Conversation

@alxhub

@alxhub alxhub commented Aug 24, 2016

Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moduleFactoryPrefix would be better since we are generating module factories

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the ES6 module prefix for the factory (for the NgModule).

@IgorMinar IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 24, 2016
@IgorMinar IgorMinar added this to the 2.0.0-rc.6 milestone Aug 24, 2016
@IgorMinar

Copy link
Copy Markdown
Contributor

@wardbell @StephenFluin this is to solve the problem you came across yesterday. with the module loader configuration we'll be able to correctly retrieve the module factory from ngfactory directory or whatever directory you specified via genDir

@alxhub
alxhub force-pushed the system-module-prefix branch 2 times, most recently from 8620e32 to 3527dea Compare August 24, 2016 22:36
@alxhub
alxhub force-pushed the system-module-prefix branch 2 times, most recently from ba4aa9f to c26ebe8 Compare August 24, 2016 22:56
@alxhub alxhub added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Aug 24, 2016
@alxhub
alxhub force-pushed the system-module-prefix branch from c26ebe8 to d531efd Compare August 24, 2016 22:57
@vicb
vicb merged commit 8b78281 into angular:master Aug 24, 2016
@hansl

hansl commented Sep 5, 2016 •

Copy link
Copy Markdown
Contributor

@alxhub This breaks webpack (not just angular-CLI) because it does not recognize this._system().import() as being a System.import() call. It fails to refactor the call into a __webpack_require_() which looks up a table of name => chunks. It then tries to use System off global which does not exist.

Why do you need parameterization of System itself? If it's for mocking, you could just mock global.System instead.

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants