Restore support for pathMapping in apps using ngc#10602
Merged
Conversation
alexeagle
added
the
action: review
mhevery
added
pr_state: LGTM
and removed
action: review
This fixes a regression in angular#10486
alexeagle
added a commit
to alexeagle/angular
that referenced
this pull request
Aug 12, 2016
…g imports (angular#10602)" This reverts commit beadf61.
3 tasks
mhevery
added a commit
to mhevery/angular
that referenced
this pull request
Aug 13, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves the comment I added here: https://github.com/angular/angular/pull/10486/files#r73911617
by reverting the logic in
reflector_host.tsand re-implementing using the original approach:for a list of candidate import statements, ask TypeScript to do moduleResolution on them to see if they resolve to the file we want to import.
Add a new option to
angularCompilerOptionscalledwriteImportsForRootDirswhich defaults to false. When it's true, we write the./style imports so that users can use TS 1.9 pathMapping to make the generated code appear in a unified source tree with the application sources. We do this in google3 for example.