Skip to content

fix(linker): prevent pollution of empty embeddedView context - #10548

Merged
alxhub merged 1 commit into
angular:masterfrom
pkozlowski-opensource:issue_10045
Aug 8, 2016
Merged

alxhub merged 1 commit into
angular:masterfrom
pkozlowski-opensource:issue_10045

Conversation

@pkozlowski-opensource

Copy link
Copy Markdown
Member

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix

What is the current behavior? (You can also link to an open issue here)

It is possible to pollute / share context of embeddedView, see #10045

Does this PR introduce a breaking change? (check one with "x")

[ x] No

Other information:

This is a super-corner case but since someone bumped into it...
Fixes #10045

@pkozlowski-opensource pkozlowski-opensource added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 6, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

context || {}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@vicb vicb added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Aug 8, 2016
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 8, 2016
@alxhub
alxhub merged commit 46bbcef into angular:master Aug 8, 2016
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TemplateRef shares context between instances when none is provided

4 participants