fix: put all ngc files into a single directory#10486
Merged
Merged
Conversation
IgorMinar
added
pr_state: LGTM
action: cleanup
Contributor
There was a problem hiding this comment.
The above comment no longer seem applicable as this no longer calls resolve().
Contributor
Prior to this change `ngc` would place generated files which refer to components in the node_modules into the node_module. This is an issue. Now all of the files are forced into a single directory as specified in `tsconfig.json` by the `genDir` option. see: https://docs.google.com/document/d/1OgP1RIpZ-lWUc4113J3w13HTDcW-1-0o7TuGz0tGx0g
Contributor
Author
|
Tests added |
| } else { | ||
| if (!this.isGenDirChildOfRootDir) { | ||
| // assume that they are on top of each other. | ||
| importedFile = importedFile.replace(this.options.basePath, this.options.genDir); |
Contributor
There was a problem hiding this comment.
this change is broken - we used to support pathMapping by trying candidate paths through the moduleResolver, but now we don't. it breaks google3. @vikerman
alexeagle
added a commit
to alexeagle/angular
that referenced
this pull request
Aug 9, 2016
This fixes a regression in angular#10486
alxhub
pushed a commit
that referenced
this pull request
Aug 9, 2016
This fixes a regression in #10486
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")
Other information:
Prior to this change
ngcwould place generated files which referto components in the node_modules into the node_module. This is an
issue. Now all of the files are forced into a single directory
as specified in
tsconfig.jsonby thegenDiroption.see: https://docs.google.com/document/d/1OgP1RIpZ-lWUc4113J3w13HTDcW-1-0o7TuGz0tGx0g