Repository navigation
CompilerConfig should take options as named params #8933
Description
- I'm submitting a ...
- feature request
From #8906 (comment)
cc/ @vicb
Current behavior
All are general arguments.
class CompilerConfig {
constructor(public genDebugInfo: boolean, public logBindingUpdate: boolean,
public useJit: boolean, renderTypes: RenderTypes = null,
interpolation: InterpolationConfig = null,
defaultEncapsulation: ViewEncapsulation = null) {
}
}
Expected/desired behavior
interface CompilerConfigArgs {
genDebugInfo: boolean;
logBindingUpdate: boolean;
useJit: boolean;
renderTypes?: RenderTypes;
...
}
class CompilerConfig {
constructor(args: CompilerConfigArgs) {
}
}
Metadata
Metadata
Assignees
Labels
No labels
Activity
vicb commentedon Jun 1, 2016
@laco0416 do you have time to take a look at this ?
We need to keep backward compatibility, so the ctor signature should look like:
constructor(enDebugInfo: boolean | CompilerConfigArgs, <other args>)lacolaco commentedon Jun 1, 2016
One way is a static method
CompilerConfig.create({...})and make constructor deprecated
lacolaco commentedon Jun 14, 2016
bc888bf solved this.
angular-automatic-lock-bot commentedon Sep 8, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.