Skip to content

[i18n] do not extract message when there is not child nodes #8802

Closed

Description

@vicb

<div i18n></div> should not create a new message

Activity

  1. self-assigned this
    on May 23, 2016
  2. manekinekko commented on Jun 12, 2016

    @manekinekko
    Contributor

    @vicb I'm working on this one

  3. manekinekko commented on Jun 14, 2016

    @manekinekko
    Contributor

    @vicb could you provide a couple more examples that should not create new messages ? I need to make sure my spec tests are solid :)

  4. vicb commented on Jun 15, 2016

    @vicb
    ContributorAuthor

    I have nothing else in mind

  5. manekinekko commented on Jun 15, 2016

    @manekinekko
    Contributor

    what about the following examples ?

    <div i18n></div>
    <div i18n>text</div>
    <div i18n><b></b></div>
    <div i18n><b>text</b></div>
    
  6. vicb commented on Jun 15, 2016

    @vicb
    ContributorAuthor

    when there is no child text node

    On Wed, Jun 15, 2016 at 1:14 PM, Wassim Chegham notifications@github.com
    wrote:

    what about the following examples ?

    text
    text

    —
    You are receiving this because you were mentioned.
    Reply to this email directly, view it on GitHub
    #8802 (comment),
    or mute the thread
    https://github.com/notifications/unsubscribe/AAPL8gHbGxAr_dRAn3sdbc5GVx8ACLjJks5qMF0MgaJpZM4Ik8ZB
    .

  7. angular-automatic-lock-bot commented on Sep 9, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  8. locked and limited conversation to collaborators on Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area: i18nIssues related to localization and internationalizationtype: bug/fix

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions