You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(ngContent): rename <ng-content> to <ng-slot> #3882
We can stick with just slot too, the more interesting question is, if we want to implements this or not. @tbosch thank you for the doc! I just read it and it makes also (finally) clear why we have ng-content.
So based on that document it really seems like slot is not hard to implement as it boils down to ng-content select="[slot...", however, I'd say we can add this, as soon as people are actually asking for it. I could imagine that very few users (if at all) will have a use case for that. That might change in the future tho.
We should stick with content. We have content injection, content change detection, contentBindings, etc. In all of those cases slot does not make sense.
We may implement the new functionality, but that is outside the scope of this issue.
Activity
tamascsaba commentedon Sep 16, 2015
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/Ez2cuT0KmQo/eUpSsU-uAgAJ
0x-r4bbit commentedon Sep 16, 2015
I think I saw in the weekly meeting notes that
<ng-content>is going to stay and<ng-slot>will be addedmhevery commentedon Sep 28, 2015
@tbosch can you comment
tbosch commentedon Oct 9, 2015
slotattribute for child nodes).So far we stick with
<ng-content>...tbosch commentedon Oct 9, 2015
We can add
ng-slottrivially though, if users really want it...vicb commentedon Oct 9, 2015
IMO renaming it to
<ng-slot>would be confusing for users (vs<slot>).0x-r4bbit commentedon Oct 11, 2015
We can stick with just
slottoo, the more interesting question is, if we want to implements this or not. @tbosch thank you for the doc! I just read it and it makes also (finally) clear why we haveng-content.So based on that document it really seems like
slotis not hard to implement as it boils down tong-content select="[slot...", however, I'd say we can add this, as soon as people are actually asking for it. I could imagine that very few users (if at all) will have a use case for that. That might change in the future tho.mhevery commentedon Oct 26, 2015
We should stick with
content. We have content injection, content change detection, contentBindings, etc. In all of those cases slot does not make sense.We may implement the new functionality, but that is outside the scope of this issue.
Closing.
angular-automatic-lock-bot commentedon Sep 7, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.