Repository navigation
Forms: refactor common validators used in unit tests and extract them to util file #37831
Description
🐞 bug report
Affected Package
The issue is caused by package @angular/formsIs this a regression?
No, this is a refactor of the existing unit tests
Description
Following #22575 , further refactoring around async validators in forms unit tests were suggested by @AndrewKushnir
#22575 (comment)
I was thinking if we can extract common validators code into a new
packages/forms/test/util.tsfile (we can store more functions there later). Some validators that are used across many tests (may be you can find more):
- function asyncValidator
- function asyncValidatorReturningObservable
- may be
simpleAsyncValidatoradded in this test can use some common code fromasyncValidator- I also see a value of moving the
currentStateOffunction (added in this PR) into theutil.tsfile, so we can reuse it for other validators-related tests in other files
🔬 Minimal Reproduction
N/A
🔥 Exception or Error
N/A
🌍 Your Environment
Angular Version:
master branch
Anything else relevant?
No
Activity
benbraou commentedon Jun 29, 2020
@AndrewKushnir I will be working on this ticket as agreed in #22575 (comment)
Thank you
refactor(forms): refactor common validators used in unit tests
refactor(forms): refactor common validators used in unit tests (angul…
refactor(forms): refactor common validators used in unit tests (angul…
angular-automatic-lock-bot commentedon Aug 23, 2020
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.
refactor(forms): refactor common validators used in unit tests (angul…