Skip to content

FormControlDirective and FormControlName do not call setDisabledState on ControlValueAcessor instances when the CVA is added and is enabled #35309

Closed

Description

@jermowery

🐞 bug report

Affected Package

@angular/forms

Is this a regression?

Not that I know of.

Description

When you add a CVA to a form via the FormControlDirective directive or FormControlName directive with reactive forms and the CVA has implemented setDisabledState the the setDisabledState and the FormControl instance is enabled, setDisabledState is not called on the CVA instance, it is however called with the FormControl is disabled.

🔬 Minimal Reproduction

https://stackblitz.com/edit/angular-issue-repro2-3fagzc

🌍 Your Environment

Angular Version:



google3 head

Anything else relevant?

Nope

Activity

  1. modified the milestone: needsTriage on Feb 10, 2020
  2. added
    forms: Controls APIIssues related to AbstractControl, FormControl, FormGroup, FormArray.
    and removed
    forms: Controls APIIssues related to AbstractControl, FormControl, FormGroup, FormArray.
    on May 25, 2020
  3. AndrewKushnir commented on May 27, 2020

    @AndrewKushnir
    Contributor

    FYI this issue is potentially related to #13856.

  4. added
    P2The issue is important to a large percentage of users, with a workaround
    P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
    on Oct 22, 2020
  5. modified the milestones: needsTriage, Backlog on Oct 22, 2020
  6. 43 remaining items

  7. added
    action: mergeThe PR is ready for merge by the caretaker
    merge: caretaker noteAlert the caretaker performing the merge to check the PR for an out of normal action needed or note
    on Oct 10, 2022
  8. dylhunn commented on Oct 10, 2022

    @dylhunn
    Contributor

    Whoops, this is the issue, not the PR :)

  9. removed
    action: mergeThe PR is ready for merge by the caretaker
    merge: caretaker noteAlert the caretaker performing the merge to check the PR for an out of normal action needed or note
    on Oct 10, 2022
  10. added a commit that references this issue on Oct 11, 2022
    6ab382e
  11. angular-automatic-lock-bot commented on Nov 11, 2022

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  12. locked and limited conversation to collaborators on Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

P2The issue is important to a large percentage of users, with a workaroundarea: formscanonicalThis issue represents a canonical design issue in Angular.state: confirmedstate: has PRtype: bug/fix

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions