Activity

1. compeek commented on Sep 17, 2019

   

   compeek

   on Sep 17, 2019

   Last edited by compeek

   More actions

   I had a lot of these kinds of errors trying to get my project working with Angular 9 and Ivy. I could not pinpoint the exact cause, the the combination of these two things seemed to resolved them for the most part:

   1. Add "allowEmptyCodegenFiles": true to the "angularCompilerOptions" block in tsconfig.json
   2. Add this npm script: "postinstall": "ivy-ngcc" to package.json and then delete node_modules completely and rerun npm install (which will run the postinstall script automatically)

   I would recommend you try each of those and see if it gives you any better results.

   I'm not using mydatepicker, but I suspect your problems aren't specific to mydatepicker. My experience with Ivy so far in the last few days unfortunately has been that it's still very finicky, especially with third party libraries and/or lazy loaded modules (not sure which is the exact cause).

   In particular with suggestion 2 above, even though the compiler automatically runs the ngcc compiler now (from what I gather, anyway), it doesn't seem to do it properly because I get better results running it manually first with that npm script.

   ❤️React with ❤️1Reacted by Boris
2. AndrewKushnir

   added

   comp: ngcc

   on Sep 17, 2019
3. ngbot

   added this to the needsTriage milestone on Sep 17, 2019
4. whyboris commented on Sep 18, 2019

   

   whyboris

   on Sep 18, 2019

   Last edited by whyboris

   Author

   More actions

   Thank you @compeek -- I added allowEmptyCodeGenFiles, postinstall, removed node_modules and ran npm install again. Unfortunately in my case I still get the above errors.

   I suspect what you recommend makes a difference, but perhaps I should just move on from mydatepicker (latest versions 2.6.6, last updated 1 year ago) to angular-mydatepicker, its successor 🤷‍♂

   Either way it may be worth for the Angular team to investigate why a simple version upgrade breaks things (even without turning Ivy on) 😕
5. whyboris commented on Sep 18, 2019

   

   whyboris

   on Sep 18, 2019

   Last edited by whyboris

   Author

   More actions

   For reference, I created a branch new-datepicker using angular-mydatepicker library instead of mydatepicker -- the PR for it: https://github.com/whyboris/angular-ivy-problem/pull/3
   It works with Angular 9 (current latest 9.0.0-next.5) 🎉 even with Ivy enabled 🎉 🎉

   🎉React with 🎉1Reacted by Alex Hauck
6. JoostK commented on Sep 26, 2019

   

   JoostK

   on Sep 26, 2019

   Member

   More actions

   Finally found some time to look into this. The mydatepicker lib is not processed by itself as its library structure follows an unusual layout, where index.js/index.d.ts files are at the root, but Angular's metadata file is stored at dist/index.metadata.json. ngcc needs some hint to know this is indeed an Angular package that needs to be processed, which can be accomplished by creating a ngcc.config.js (that's .js, not .json!) file in the root of the project (next to the root package.json):

   module.exports = {
     packages: {
       'mydatepicker': {
         entryPoints: {
           '.': {}
         }
       },
     },
   };

   This is enough to teach ngcc that mydatepicker needs to be processed as an Angular library. With this config, the library is processed correctly and the app compiles successfully.

   Unfortunately, the app will fail at runtime:

   NullInjectorError: R3InjectorError(AppModule)[Renderer -> Renderer -> Renderer]: 
     NullInjectorError: No provider for Renderer!
   

   The Renderer API has been deprecated a long time ago and is no longer available in Ivy, so the library is just no longer compatible.

   The error that is being reported is less than ideal, as it doesn't really tell why it's failing nor what can be done to rectify the issue. If you have suggestions for improving the situation, please let us know.

   Regarding this particular issue, I don't see how it's actionable at this moment so I will go ahead and close it for now.

   👍React with 👍1Reacted by Boris

   🎉React with 🎉1Reacted by Boris

   ❤️React with ❤️1Reacted by Boris
7. JoostK

   closed this as completedon Sep 26, 2019
8. whyboris commented on Sep 28, 2019

   

   whyboris

   on Sep 28, 2019

   Author

   More actions

   Thank you @JoostK -- hope the time you spent looking into this issue wasn't a waste. I think it's very sensible for Angular to allow for some outdated versions of libraries to not be compatible with new versions of Angular 👌

   For anyone coming across similar problems upgrading to Angular 9, the best recommendation is:

   • Update the library mydatepicker to its successor angular-mydatepicker

   This is a sensible solution because mydatepicker hasn't been updated in 1 year: https://www.npmjs.com/package/mydatepicker?activeTab=versions

   And its official repository (https://github.com/kekeh/mydatepicker) recommends you upgrade to the successor (https://github.com/kekeh/angular-mydatepicker), also written by the same author. This new version was released as recently as 2 months ago: https://www.npmjs.com/package/angular-mydatepicker

   👏 keep 👏 dependencies 👏 up 👏 to 👏 date 👏

   Cheers ❤️
9. angular-automatic-lock-bot commented on Oct 29, 2019

   

   angular-automatic-lock-botBot

   on Oct 29, 2019

   More actions

   This issue has been automatically locked due to inactivity.
   Please file a new issue if you are encountering a similar or related problem.

   Read more about our automatic conversation locking policy.

   _{This action has been performed automatically by a bot.}
10. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Oct 29, 2019