Activity

1. kara

   added

   comp: ivy

   on Aug 9, 2019
2. ngbot

   added this to the needsTriage milestone on Aug 9, 2019
3. JoostK commented on Aug 10, 2019

   

   JoostK

   on Aug 10, 2019

   Last edited by JoostK

   Member

   More actions

   I am seeing something very strange here. When compiling with the CLI, the following code is generated into vendor-es2015.js:

   ItemsComponent.ngComponentDef = _angular_core__WEBPACK_IMPORTED_MODULE_1__["ɵɵdefineComponent"]({ type: ItemsComponent, selectors: [["app-items"]], factory: function ItemsComponent_Factory(t) { return new (t || ItemsComponent)(_angular_core__WEBPACK_IMPORTED_MODULE_1__["ɵɵdirectiveInject"](_angular_core__WEBPACK_IMPORTED_MODULE_1__["ChangeDetectorRef"])); }, inputs: { count: "count" }, features: [_angular_core__WEBPACK_IMPORTED_MODULE_1__["ɵɵNgOnChangesFeature"]()], consts: 2, vars: 2, template: function ItemsComponent_Template(rf, ctx) { if (rf & 1) {
           _angular_core__WEBPACK_IMPORTED_MODULE_1__["ɵɵelementStart"](0, "div", _c0);
           _angular_core__WEBPACK_IMPORTED_MODULE_1__["ɵɵtemplate"](1, ItemsComponent_div_1_Template, 2, 1, "div", _c1);
           _angular_core__WEBPACK_IMPORTED_MODULE_1__["ɵɵelementEnd"]();
       } if (rf & 2) {
           _angular_core__WEBPACK_IMPORTED_MODULE_1__["ɵɵselect"](1);
           _angular_core__WEBPACK_IMPORTED_MODULE_1__["ɵɵproperty"]("ngForOf", ctx.items)("ngForTrackBy", ctx.trackByFn);
       } }, encapsulation: 2, changeDetection: 0 });

   However, just running ngc inside the repo results in the following:

   ItemsComponent.ngComponentDef = i0.ɵɵdefineComponent({ type: ItemsComponent, selectors: [["app-items"]], factory: function ItemsComponent_Factory(t) { return new (t || ItemsComponent)(i0.ɵɵdirectiveInject(i0.ChangeDetectorRef)); }, inputs: { count: "count" }, features: [i0.ɵɵNgOnChangesFeature()], consts: 2, vars: 2, template: function ItemsComponent_Template(rf, ctx) { if (rf & 1) {
           i0.ɵɵelementStart(0, "div", _c0);
           i0.ɵɵtemplate(1, ItemsComponent_div_1_Template, 2, 1, "div", _c1);
           i0.ɵɵelementEnd();
       } if (rf & 2) {
           i0.ɵɵselect(1);
           i0.ɵɵproperty("ngForOf", ctx.items)("ngForTrackBy", ctx.trackByFn);
       } }, directives: [i1.NgForOf], encapsulation: 2, changeDetection: 0 });

   Note that the ngc output contains directives: [i1.NgForOf], which is missing from the code inside of vendor-es2015.js when using the CLI. This piece of generated code would have enabled the component to use the NgForOf directive at runtime, so it being elided will prevent it from being used at runtime.

   I have no clue why all of the directives get elided. The Angular compiler does generate the directives: [i1.NgForOf] code regardless of ngc vs CLI, and the emitted source file emitted from ngtsc does also contain that piece of code. So, it appears as if some transform later in the pipeline elides it from the code.

   ---

   When the code inside ./src/lib is moved under ./src/app/lib and the import of ComponentsModule is changed into ./lib/components.module instead of angular-test, the code is generated properly into main-es2015.js. So this being treated as a library does affect the final bundle code.

   ---

   EDIT: All of the above is not really relevant, as apparently angular-test is actually installed into node_modules and processed by ngcc 🤦‍♂
4. JoostK

   added

   comp: ngcc

   and removed

   comp: ivy

   on Aug 11, 2019
5. JoostK commented on Aug 11, 2019

   

   JoostK

   on Aug 11, 2019

   Member

   More actions

   So, the bug is with ngcc, where the ItemsComponent's metadata has a declaration node of class ItemsComponent {} (the inner class declaration), whereas the component's scope (i.e. its registration in ComponentsModule) is registered under let ItemsComponent = class ItemsComponent {} (the outer class declaration). Therefore, the scope of the component can't be determined which results in the directives: [i1.NgForOf] to be missing from the compiled code.
6. fr0 commented on Aug 28, 2019

   

   fr0

   on Aug 28, 2019

   Author

   More actions

   Related: ng-packagr/ng-packagr#1278
7. alxhub

   added

   freq1: low

   severity3: broken

   type: bug/fix

   on Sep 5, 2019
8. ngbot

   modified the milestones: needsTriage, Backlog on Sep 5, 2019
9. kara

   closed this as completedin 373e133on Sep 12, 2019
10. angular-automatic-lock-bot commented on Oct 13, 2019

    

    angular-automatic-lock-botBot

    on Oct 13, 2019

    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    _{This action has been performed automatically by a bot.}
11. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Oct 13, 2019