You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs: observables examples hard-coded and outdated #31024
The Comparing Observables guide shows examples with the old, obsolete syntax of having operators on the Observable prototype, instead of using .pipe().
Also, the examples are hard-coded, instead of being extracted from actual mini-apps, which would prevent the code from getting out-of-date or break.
@kapunahelewong / @gkalpak Looking at the link you provided, I don't see the old syntax. I see the new syntax using .pipe(...). Can you let me know if any changes are still required? I would be willing to pick up this work if still required.
Activity
sonukapoor commentedon Dec 7, 2019
@kapunahelewong / @gkalpak Looking at the link you provided, I don't see the old syntax. I see the new syntax using
.pipe(...). Can you let me know if any changes are still required? I would be willing to pick up this work if still required.gkalpak commentedon Dec 9, 2019
Thx, @sonukapoor!
This issues had basically two parts:
aio/content/examples/).The first part has already been addressed by #31074. The second still needs to be addressed.
sonukapoor commentedon Dec 9, 2019
Sounds good. Please assign to me if it’s still available.
kapunahelewong commentedon Dec 9, 2019
@sonukapoor, if you need any help with the PR, please let me know. Thank you!!
fix(docs-infra): convert hard-coded `comparing-observables` examples …
angular-automatic-lock-bot commentedon Feb 21, 2020
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.