Skip to content

docs: observables examples hard-coded and outdated #31024

Closed

Description

@gkalpak

📚 Docs or angular.io bug report

Description

The Comparing Observables guide shows examples with the old, obsolete syntax of having operators on the Observable prototype, instead of using .pipe().

Also, the examples are hard-coded, instead of being extracted from actual mini-apps, which would prevent the code from getting out-of-date or break.

🔬 Minimal Reproduction

What's the affected URL?**

https://angular.io/guide/comparing-observables

Activity

  1. modified the milestone: needsTriage on Jun 13, 2019
  2. modified the milestones: needsTriage, Backlog on Jun 13, 2019
  3. sonukapoor commented on Dec 7, 2019

    @sonukapoor
    Contributor

    @kapunahelewong / @gkalpak Looking at the link you provided, I don't see the old syntax. I see the new syntax using .pipe(...). Can you let me know if any changes are still required? I would be willing to pick up this work if still required.

  4. gkalpak commented on Dec 9, 2019

    @gkalpak
    MemberAuthor

    Thx, @sonukapoor!

    This issues had basically two parts:

    1. Updating the examples to use the new syntax (pipeable operators).
    2. Moving the examples (which are currently hard-coded) to proper, testable mini-apps (in aio/content/examples/).

    The first part has already been addressed by #31074. The second still needs to be addressed.

  5. sonukapoor commented on Dec 9, 2019

    @sonukapoor
    Contributor

    Sounds good. Please assign to me if it’s still available.

  6. kapunahelewong commented on Dec 9, 2019

    @kapunahelewong
    Contributor

    @sonukapoor, if you need any help with the PR, please let me know. Thank you!!

  7. added a commit that references this issue on Jan 21, 2020
    4eec1a9
  8. angular-automatic-lock-bot commented on Feb 21, 2020

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  9. locked and limited conversation to collaborators on Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions