Skip to content

Remove deprecated features from docs examples #30620

Closed

Description

@kapunahelewong

📚 Docs or angular.io bug report

Description

We need to remove deprecated features from docs examples.

EDIT: Specifically, see @trotyl's comment below. (Thanks, @trotyl!)

🔬 Minimal Reproduction

What's the affected URL?**

One example is here:
https://angular.io/guide/dynamic-component-loader#resolving-components

As noted by @trotyl in #30598 (review)

Reproduction Steps**

Expected vs Actual Behavior**

Examples in documentation should be up-to-date.

📷Screenshot

🔥 Exception or Error





🌍 Your Environment

Browser info

N/A

Anything else relevant?

Activity

  1. added this to the Backlog milestone on May 22, 2019
  2. trotyl commented on May 23, 2019

    @trotyl
    Contributor

    We need to remove deprecated features from docs examples.

    Sorry for the confusion, I guess in this specific case the proper action is to add { static: true } into @ViewChild().


    EDIT: technically it's still removing the deprecated feature, it's all right.

  3. kapunahelewong commented on Jun 7, 2019

    @kapunahelewong
    ContributorAuthor

    @ViewChild() in docs examples fixed by #30639 🙌🏼

    Closing this issue. Will open new ones if I find other features to update.

    Thanks for helping me, @trotyl!

  4. angular-automatic-lock-bot commented on Sep 15, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  5. locked and limited conversation to collaborators on Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions