Repository navigation
ivy-ngcc is unable to recognise AngularFireModule.initializeApp as ModuleWithProviders #29078
Description
🐞 bug report
Affected Package
The issue is caused by package @angular/compiler-cli
Is this a regression?
No
Description
Take a look at this code (taken from https://unpkg.com/@angular/fire@5.1.1/es2015/firebase.app.module.js):
let AngularFireModule = AngularFireModule_1 = class AngularFireModule {
static initializeApp(options, nameOrConfig) {
return {
ngModule: AngularFireModule_1,
providers: [
{ provide: FirebaseOptionsToken, useValue: options },
{ provide: FirebaseNameOrConfigToken, useValue: nameOrConfig }
]
};
}
};
AngularFireModule = AngularFireModule_1 = __decorate([
NgModule({
providers: [FirebaseAppProvider],
})
], AngularFireModule);
export { AngularFireModule };ivy-ngcc cannot recognise the AngularFireModule.initializeApp and mark it as ModuleWithProviders.
This is because the current implementation of ivy-ngcc which looks for ts.ClassDeclaration. Instead, the code above is a variable assignment to ts.BinaryExpression which includes ts.ClassExpression.
There are 2 solutions to this issue:
- Make
ivy-ngccto able to recognise class declaration like this. - Tell library authors to use
angularCompilerOptions.annotationsAsasstatic fieldsduring packaging.
My voice is with solution 2, though.
🔬 Minimal Reproduction
N/A
🔥 Exception or Error
N/A
🌍 Your Environment
Angular Version:
8.0.0-beta.6
Anything else relevant?
This causes #28603.
Reacted by Joost Koehoorn and Naveed Ahmed
Metadata
Metadata
Assignees
Labels
No labels
Activity
StephenFluin commentedon Mar 3, 2019
For future search reference, the symptom I'm seeing that I believe is caused by this is the error:
Error: Value at position 4 in imports array is not a reference: [object Object]with position depending on where you have theModuleWithProvidersin the import array.sarunint commentedon Mar 3, 2019
@StephenFluin That's the exact error message that makes me go through debugging the
ivy-ngcc.By the way, what's the intended solution for this: fix
ivy-ngccor fix the library?petebacondarwin commentedon Mar 4, 2019
The fix needs to be in the ngcc tool.
fix(ivy): ngcc - properly handle aliases class expressions
fix(ivy): ngcc - properly handle aliases class expressions (angular#2…
angular-automatic-lock-bot commentedon Sep 14, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.