Repository navigation
Tour of Heroes doesn't compile with Ivy and angular-in-memory-web-api #28603
Description
🐞 bug report
Affected Package
The issue is caused by package @angular/....Is this a regression?
Yes
Description
A clear and concise description of the problem...When using Ivy/ngcc with angular-in-memory-api version 0.8.0, the app does not compile and emits an error.
The app currently works under V7 and V8 without Ivy with no issues.
🔬 Minimal Reproduction
https://github.com/brandonroberts/ivy-in-memoryInstructions to reproduce are in the README
🔥 Exception or Error
```
ERROR in Value at position 4 in imports array is not a reference: [object Object]
```
🌍 Your Environment
Angular Version:
Angular CLI: 7.1.4
Node: 10.14.2
OS: linux x64
Angular: 8.0.0-beta.3
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Package Version
-----------------------------------------------------------
@angular-devkit/architect 0.11.4
@angular-devkit/build-angular 0.11.4
@angular-devkit/build-optimizer 0.11.4
@angular-devkit/build-webpack 0.11.4
@angular-devkit/core 7.1.4
@angular-devkit/schematics 7.1.4
@angular/cli 7.1.4
@ngtools/webpack 7.1.4
@schematics/angular 7.1.4
@schematics/update 0.11.4
rxjs 6.3.3
typescript 3.1.6
webpack 4.23.1
Anything else relevant?
I did an additional build of angular-in-memory-web-api with ng-packagr and 8.0.0-beta.3 and the app works correctly under Ivy/ngcc.
Build repo is here: https://github.com/brandonroberts/in-memory-web-api-bazel
Build branch is here: https://github.com/brandonroberts/in-memory-web-api/tree/ng-packagr-build
Reacted by Elvis Begovic
Activity
alexzuza commentedon Feb 7, 2019
Ivy compiler does not resolve ModuleWithProviders yet.
angular/packages/compiler-cli/src/ngtsc/annotations/src/ng_module.ts
Lines 331 to 332 in 50732e1
cc @alxhub
alxhub commentedon Feb 7, 2019
I think that
TODOis incorrect, we do indeed processModuleWithProviders(a few lines above, actually, with another comment).petebacondarwin commentedon Feb 8, 2019
But it looks like the error that is being reported in this issue comes from that line.
brandonroberts commentedon Apr 10, 2019
I'm still seeing this issue with the latest beta(11). Was #29119 supposed to fix this issue @JoostK?
brandonroberts commentedon Apr 10, 2019
I've updated the repo also https://github.com/brandonroberts/ivy-in-memory
cc: @alxhub
JoostK commentedon Apr 11, 2019
@brandonroberts Hmm, seeing that angular-in-memory-web-api also has that
InMemoryWebApiModule_1indirection going on it should be supported with #29119. I'm not sure what would prevent this from working this time around, I'll need to take a look at it.JoostK commentedon Apr 13, 2019
Okay, I ran through the repro and have found the culprit on why
angular-in-memory-web-apiis causing problems. The root issue is that itspackage.jsondoes not specify atypingsnortypesissue, whichngcctests as a prerequisite for processing an entry-point:angular/packages/compiler-cli/ngcc/src/packages/entry_point.ts
Lines 83 to 87 in ea70d41
The
nullreturn causes the entry-point to be dropped from further processing, as it is considered not to be an Angular package at all.JoostK commentedon Apr 28, 2019
Tracked as FW-1299
16 remaining items
docs: allow custom package version for example zip file dependencies
fix(ivy): ngcc - infer entry-point typings from format paths
angular-automatic-lock-bot commentedon Sep 15, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.