You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ngcc: no ngModuleDef and ngInjectorDef on BrowserModule for esm5 and fesm5 #28110
After running ivy-ngcc, there are no ngModuleDef and ngInjectorDef on BrowserModule for esm5 and fesm5
For esm2015 and fesm2015 they are generated correctly.
For other modules like ApplicationModule, they are generated for all formats, including esm5 and fesm5.
There are markers modified_by_ngcc_for_esm5 and modified_by_ngcc_for_fesm5 , so there is some prove that ngcc has at least tried to process esm5 and fesm5 for angular/platform-browser
@alexzuza , thank you. I am quite sure you are right.
Unfortunately, I cannot verify, since with github:angular/compiler-cli-builds I get an error now:
Compiling @angular/common - fesm2015
TypeError: Cannot read property 'usesOnChanges' of undefined
at addFeatures (.....\node_modules\@angular\compiler\bundles\compiler.umd.js:14997:28)
at Object.compileDirectiveFromMetadata (.....\node_modules\@angular\compiler\bundles\compiler.umd.js:15009:9)
Activity
alexzuza commentedon Jan 13, 2019
Looks like it has been covereder by #27848. But it has not been released yet.
Can you try it with current version of @angular/compiler-cli?
package.json
stefanocke commentedon Jan 13, 2019
@alexzuza , thank you. I am quite sure you are right.
Unfortunately, I cannot verify, since with github:angular/compiler-cli-builds I get an error now:
alexzuza commentedon Jan 13, 2019
@stefanocke Try using the same version of other angular packages
Here's an example https://github.com/StephenFluin/i18n-sample/blob/e2cb2006c614fce0f6d623def5f13174583233d3/package.json#L15
stefanocke commentedon Jan 13, 2019
@alexzuza works. Thanks again.
Using Ivy with option ngtsc
angular-automatic-lock-bot commentedon Sep 14, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.