Skip to content

ngcc: no ngModuleDef and ngInjectorDef on BrowserModule for esm5 and fesm5 #28110

Closed

Description

@stefanocke

🐞 bug report

Affected Package

  • ivy-ngcc
  • angular/platform-browser

Description

  • After running ivy-ngcc, there are no ngModuleDef and ngInjectorDef on BrowserModule for esm5 and fesm5
  • For esm2015 and fesm2015 they are generated correctly.
  • For other modules like ApplicationModule, they are generated for all formats, including esm5 and fesm5.
  • There are markers modified_by_ngcc_for_esm5 and modified_by_ngcc_for_fesm5 , so there is some prove that ngcc has at least tried to process esm5 and fesm5 for angular/platform-browser

🔬 Minimal Reproduction

  • Run ivy-ngcc in Angular 7.2.0 project.

Versions

  • Angular Version: 7.2.0

Activity

  1. alexzuza commented on Jan 13, 2019

    @alexzuza
    Contributor

    Looks like it has been covereder by #27848. But it has not been released yet.

    Can you try it with current version of @angular/compiler-cli?

    package.json

    "devDependencies": {
      "@angular/compiler-cli": "github:angular/compiler-cli-builds"
    }
    
  2. stefanocke commented on Jan 13, 2019

    @stefanocke
    Author

    @alexzuza , thank you. I am quite sure you are right.
    Unfortunately, I cannot verify, since with github:angular/compiler-cli-builds I get an error now:

    Compiling @angular/common - fesm2015
    TypeError: Cannot read property 'usesOnChanges' of undefined
        at addFeatures (.....\node_modules\@angular\compiler\bundles\compiler.umd.js:14997:28)
        at Object.compileDirectiveFromMetadata (.....\node_modules\@angular\compiler\bundles\compiler.umd.js:15009:9)
    
  3. alexzuza commented on Jan 13, 2019

    @alexzuza
    Contributor
  4. stefanocke commented on Jan 13, 2019

    @stefanocke
    Author

    @alexzuza works. Thanks again.

  5. added a commit that references this issue on Jan 13, 2019
  6. angular-automatic-lock-bot commented on Sep 14, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  7. locked and limited conversation to collaborators on Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions