Skip to content

Adding support for CSS variable shimming #2567

New issue
New issue
Closed as not planned
Closed as not planned
Adding support for CSS variable shimming#2567
Assignees
pkozlowski-opensource
Labels
area: coreIssues related to the framework runtimecore: stylesheetseffort3: weeksfeatureLabel used to distinguish feature request from other issuesfeature: under considerationFeature request for which voting has completed and the request is now under considerationstate: Needs Design
Milestone
Backlog

Description

@rkirov
rkirov
opened on Jun 16, 2015

Polymer 1.0 has that support and is advocating using CSS variables to pierce shadow dom boundaries instead of the /deep/ combinator. https://www.polymer-project.org/1.0/docs/devguide/styling.html

Activity

  1. TedSander commented on Jun 16, 2015

    @TedSander
    TedSander
    on Jun 16, 2015
    Contributor

    Also CSS mixins would be appreciated.

    Spec for CSS variables here:
    https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_variables

  2. mhevery
    added
    state: Needs Design
    comp: core/view/compiler
    P2: required
    effort3: weeks
    featureLabel used to distinguish feature request from other issues
    on Jun 19, 2015

  3. matanlurey commented on Jun 21, 2015

    @matanlurey
    matanlurey
    on Jun 21, 2015
    Contributor

    Could Angular also expose a Shim injectable for code that manually manipulates CSS classes?

    e.g.

    class NgStyleLikeDirective {
  constructor(CssShim cssShim) {
    cssShim('fancy-test') // Becomes fancy-test[_ng_content_628]
  }
}

  4. vicb commented on Jun 22, 2015

    @vicb
    vicb
    on Jun 22, 2015
    Contributor

    I think @matsko has plan to use CSS variables for animations. Not sure if he plan to use the code from Polymer ?

    @matanlurey could you please create a separate issue for the shim things with a more detailed explanation about your use case ?

  5. tbosch commented on Jun 22, 2015

    @tbosch
    tbosch
    on Jun 22, 2015
    Contributor

    This sounds reasonable. Note that we will probably still be able to do this already during compilation, as we will attach components already during compilation (#2529)

  6. mhevery
    added
    state: Periodic Review
    P3: important
    and removed
    state: Periodic Review
    P2: required
    on Aug 20, 2015
  7. naomiblack
    added
    hotlist: angular-core-team
    on Mar 23, 2016

  8. 3 remaining items

  9. mhevery
    added
    area: coreIssues related to the framework runtime
    and removed
    comp: core/view/compiler
    on Sep 7, 2016
  10. IgorMinar
    removed
    P3: important
    on Oct 4, 2016
  11. ngbot
    added this to the Backlog milestone on Jan 23, 2018
  12. pkozlowski-opensource
    added
    core: stylesheets
    on Mar 6, 2020
  13. jelbourn
    removed
    hotlist: angular-core-team
    on Sep 22, 2020
  14. jelbourn
    unassigned
    matsko
    on Sep 22, 2020
  15. angular-robot
    added
    votes required
    on May 21, 2021

  16. angular-robot commented on May 21, 2021

    @angular-robot
    angular-robotBot
    on May 21, 2021
    Contributor

    Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

    Find more details about Angular's feature request process in our documentation.

  17. angular-robot
    added
    feature: under considerationFeature request for which voting has completed and the request is now under consideration
    on Jun 4, 2021
  18. pkozlowski-opensource
    self-assigned this
    on Dec 3, 2021

  19. jelbourn commented on Jun 16, 2022

    @jelbourn
    jelbourn
    on Jun 16, 2022
    Contributor

    CSS Custom Properties are now supported in all browsers that Angular supports, so this is no longer necessary.

  20. jelbourn
    closed this as not plannedon Jun 16, 2022

  21. angular-automatic-lock-bot commented on Jul 17, 2022

    @angular-automatic-lock-bot
    angular-automatic-lock-botBot
    on Jul 17, 2022

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  22. angular-automatic-lock-bot
    locked and limited conversation to collaborators on Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area: coreIssues related to the framework runtimecore: stylesheetseffort3: weeksfeatureLabel used to distinguish feature request from other issuesfeature: under considerationFeature request for which voting has completed and the request is now under considerationstate: Needs Design

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions