Skip to content

aio(routing) live example is not working as expected #24638

Closed

Description

@jainanuj0812

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[X ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:

Current behavior

Live example for the route and navigations is not working as expected live example

as per the documentation: 'You'd like to send the id of the current hero with the navigation request so that the HeroListComponent can highlight that hero in its list.'

sending the id as an optional parameter to the herosList component that will be used to highlight the selected hero is not working as expected (the selected hero is not getting highlighted).

It may be due to redirectTo, it breaks the optional parameter sent to the heroes component and we are not getting hero id in the herolist component.

Expected behavior

the selected hero should get highlighted (we should get the selected heroId as a part of params in the heroList component).

Minimal reproduction of the problem with instructions

  1. Open the link - https://angular.io/generated/live-examples/router/stackblitz.html

  2. Click on Heroes

  3. Goto any of the heroes from the list. lets say - 12 Narco

  4. Click Back from the hero details.

  5. Narco should be highlighted (the optional parameter which we are passing from the hero detail component should be available in the params in the hero list component). which is not.

Activity

  1. added this to the needsTriage milestone on Jun 25, 2018
  2. modified the milestones: needsTriage, Backlog on Jun 26, 2018
  3. brandonroberts commented on Jun 26, 2018

    @brandonroberts
    Contributor

    This issue is covered in my router guide updates PR. You can view the live example preview https://pr20023-a1643e3.ngbuilds.io/

  4. brandonroberts commented on Sep 26, 2018

    @brandonroberts
    Contributor

    Fixed via #20023

  5. angular-automatic-lock-bot commented on Sep 14, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  6. locked and limited conversation to collaborators on Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions