Perhaps incorrect formatting when using currency pipe with locale de-AT #24609

Activity

1. jasonaden

   added

   area: i18nIssues related to localization and internationalizationIssues related to localization and internationalization

   on Jun 21, 2018
2. ngbot

   added this to the needsTriage milestone on Jun 21, 2018
3. cat-mandres commented on Jun 22, 2018

   

   cat-mandres

   on Jun 22, 2018

   Author

   More actions

   Can this somehow be read from the locale files in the angular repo, e.g. here?

   https://github.com/angular/angular/blob/master/packages/common/locales/de-AT.ts
   https://github.com/angular/angular/blob/master/packages/common/locales/de.ts

   I cant really find the difference in here where the other symbol is defined.
4. cat-mandres commented on Jun 22, 2018

   

   cat-mandres

   on Jun 22, 2018

   Author

   More actions

   Yes I know that - and if you now take the lines from the de-AT.ts file

   angular/packages/common/locales/de-AT.ts

   Line 54 in 637805a

   [',', ' ', ';', '%', '+', '-', 'E', '·', '‰', '∞', 'NaN', ':', '.'],

   and

   angular/packages/common/locales/de-AT.ts

   Line 55 in 637805a

   ['#,##0.###', '#,##0 %', '¤ #,##0.00', '#E0'], '€', 'Euro', {

   You get the following format for currencies get formatted:

   ¤ #,##0.00

   According to this method which is getting used by the currency pipe to get the number:

   angular/packages/common/src/i18n/locale_data_api.ts

   Line 365 in 637805a

   export function getLocaleNumberFormat(locale: string, type: NumberFormatStyle): string {

   the dot should get replaced by the character used for decimal point.

   angular/packages/common/src/i18n/locale_data_api.ts

   Line 351 in 637805a

   * | . | Replaced automatically by the character used for the decimal point. |

   now the character used for decimal point is only defined once, the first symbol in the numbers line above, which is a ,.
   Am I wrong about something here?
5. trotyl commented on Jun 25, 2018

   

   trotyl

   on Jun 25, 2018

   Last edited by trotyl

   Contributor

   More actions

   The bug is caused by the following code:

   angular/tools/gulp-tasks/cldr/extract.js

   Lines 447 to 453 in ce40e85

   	if (symbols.currencyDecimal) {
   	symbolValues.push(symbols.currencyDecimal);
   	}
   	if (symbols.currencyGroup) {
   	symbolValues.push(symbols.currencyGroup);
   	}

   There should be an else clause for currencyDecimal to push an undefined value to hold this position, like:

   if (symbols.currencyDecimal) {
     symbolValues.push(symbols.currencyDecimal);
   } else {
     symbolValues.push(undefined);
   }

   Otherwise currencyDecimal and currencyGroup would be mixed up.

   I guess a PR would be welcomed.

   Also CC: @ocombe

   👍React with 👍1Reacted by Olivier Combe
6. ocombe commented on Jun 25, 2018

   

   ocombe

   on Jun 25, 2018

   Contributor

   More actions

   Hmm that sounds about right, good find both of you, thanks!
7. ocombe

   self-assigned this

   on Jun 25, 2018
8. ocombe

   added

   type: bug/fix

   freq1: low

   severity3: broken

   on Jun 25, 2018
9. ngbot

   modified the milestones: needsTriage, Backlog on Jun 25, 2018
10. ocombe commented on Jun 25, 2018

    

    ocombe

    on Jun 25, 2018

    Contributor

    More actions

    Actually the correct format will be € 123.456.789,00 with the fix
11. 4 remaining items

    Load more

12. cat-mandres commented on Jun 25, 2018

    

    cat-mandres

    on Jun 25, 2018

    Author

    More actions

    I see.
    So am I correct that the last symbol of the following line:

    angular/packages/common/locales/de-AT.ts

    Line 54 in 637805a

    [',', ' ', ';', '%', '+', '-', 'E', '·', '‰', '∞', 'NaN', ':', '.'],

    is the digit grouping symbol used for currencies if it is defined?
    And if undefined it will fallback to the 2nd symbol of this line, the digit grouping symbol for decimals.

    E.g. in the locales/de.ts file this last symbol is undefined, which means same symbol for decimals as for currencies?
13. ocombe commented on Jun 25, 2018

    

    ocombe

    on Jun 25, 2018

    Contributor

    More actions

    Yes that is how the formatting rules are defined by CLDR, use the currency specific symbols if they are defined, or use the regular symbols otherwise.
14. mhevery

    closed this as completedin dcabb05on Jul 9, 2018
15. mhevery

    added a commit that references this issue on Jul 9, 2018

    fix(common): use correct currency format for locale de-AT (#24658)

    ...

    This issue will close once commit a92f111 is merged into the 'main' branch.

    a92f111
16. IgorMinar

    added 2 commits that reference this issue on Jul 30, 2018

    docs: refactor pipe example to use the HttpClient (#22741)

    ...

    This issue will close once commit 5399c17 is merged into the 'main' branch.

    5399c17
17. angular-automatic-lock-bot commented on Sep 13, 2019

    

    angular-automatic-lock-botBot

    on Sep 13, 2019

    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    _{This action has been performed automatically by a bot.}
18. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Sep 13, 2019