Skip to content

upgrade jasmine to 2.9 and its typings to definitely typed head version #23952

Closed

Description

@rkirov

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:

What is the motivation / use case for changing the behavior?

Google internally uses jasmine 2.9 (with typings from 2.4 sadness). We are trying to upgrade the typings to their current head on DefinitelyTyped which claims support for 2.8, but likely works with 2.9 too.

Previous attempts at upgrading jasmine have failed:

#23230
#19904

cc @vikerman

Activity

  1. added
    area: testingIssues related to Angular testing features, such as TestBed
    on May 22, 2018
  2. added this to the needsTriage milestone on May 22, 2018
  3. thorn0 commented on Jun 26, 2018

    @thorn0
    Contributor

    Why 2.9? What's wrong with Jasmine 3.x?

  4. rkirov commented on Jun 26, 2018

    @rkirov
    ContributorAuthor

    Nothing wrong with 3.x, just taking smaller incremental steps, since even getting to 2.9 seems hard enough that noone has done it. Likely 3.x would be even harder.

  5. mhevery commented on Jul 6, 2018

    @mhevery
    Contributor

    Closed by #19904

  6. added 2 commits that reference this issue on Jul 30, 2018
    5399c17
  7. angular-automatic-lock-bot commented on Sep 13, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  8. locked and limited conversation to collaborators on Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: testingIssues related to Angular testing features, such as TestBed

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions