Repository navigation
Add support for TypeScript 2.8 #23779
Description
Typescript 2.8 info:
- https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-8.html
- https://blogs.msdn.microsoft.com/typescript/2018/03/27/announcing-typescript-2-8/
Typically a TypeScript update means the following things:
- ensure that tsickle is compatible with the new version of typescript
- ensure that rxjs is compatbile
- update our main package.json and yarn.lock to reflect the typescript 2.8 dependency
- add a new test for ts28 similar to https://github.com/angular/angular/tree/77ff72f93b86e57ba3fdc67a60a5b00c69c9a824/integration/typings_test_ts27
- ensure that our codebase can compile with typescript 2.8. Usually the tighter compiler checks surface preexisting errors that we need to fix in a way that
- doesn't change our public api
- doesn't make our published d.ts files incompatible with typescript 2.7
- ensure that our code that users TS AST and compiler apis are compatible (primarily compiler-cli and language-service) - if we need to make any updates we need to make sure that we remain both 2.7 and 2.8 compatible.
- point out anything Angular-specific and noteworthy that we need to let Angular developers know when they update to 2.8 (new flags, etc)
Previous PR with 2.7 update just for reference: #22669
Reacted by Bnaya Peretz, Suguru Inatomi, Jan Melcher, Rodrigo Alves, Olaf Kasper, juergenr, Kenji Imamula, Quentin, Marvin Heilemann, rafaelfgx and 33 more
Reacted by Alan Agius, Alex Sharov, David J. M. Karlsen, Maxence Frenette, Michael Kriese, Emanuel Dejanu and Jim Rasche
Activity
IgorMinar commentedon May 8, 2018
@LucasSloan has offered to take this one on, @alxhub can you please help with code reviews? thanks!
LucasSloan commentedon May 8, 2018
There was a previous issue #23092, could you merge or link or whatever?
IgorMinar commentedon May 8, 2018
MrWolfZ commentedon Jun 24, 2018
Is someone still working on this? Or are you looking for contributors?
sarunint commentedon Jun 24, 2018
@MrWolfZ It has been done in #23782 and is scheduled for v6.1.
alan-agius4 commentedon Jun 24, 2018
1 remaining item
trotyl commentedon Jun 25, 2018
But this is a checklist, one can found which parts have already been done.
The
ensure that our codebase can compile with typescript 2.8.item mentioned above has been checked already.gkalpak commentedon Jun 25, 2018
Is there anything left to do here, @IgorMinar?
The only remaining item is:
ericmartinezr commentedon Jun 25, 2018
Shouldn't this one be superseded by #24652 ?
insidewhy commentedon Jun 26, 2018
When installing the 6.1.0-beta.2:
Can I ignore this warning or is typescript 2.8 not available in the released version? If not, do you know which version of angular ts 2.8 will be supported from?
vladimiry commentedon Jun 26, 2018
@ohjames try to put
disableTypeScriptVersionCheckoption into yourtsconfig.jsoninsidewhy commentedon Jun 26, 2018
@vladimiry I don't think that's even needed, it's just a warning from yarn/npm about peer dependency being violated. I can ignore it but I'm not sure if ts 2.8 is supported by the current 6.1 beta (mostly due to this peer dependency).
vladimiry commentedon Jun 26, 2018
IMHO, you can't know that for sure until it's officially stated by Angular team.
Btw I go with latest TS and Angular versions and usually it works well, like now using TS 2.9.2 and Angular 6.0.6, have not tried beta though.
This doesn't look like a warning to me
angular/packages/compiler-cli/src/transformers/program.ts
Line 926 in c95437f
@ohjames Ah, sorry, I overlooked your original message, in your case it's about a dependency warnings shown by npm/yarn.
zuozhiw commentedon Jul 3, 2018
@vladimiry I'm struggling to combine the latest version of typescript (TS 2.9.2 currently) and the latest Angular version (it needs TS 2.7.2). I did what you said:
disableTypeScriptVersionCheckintsconfig.json, and I also disabled thetypescriptMismatchwarning in Angular CLI.However, when I do
ng serve, I get this errorERROR in The Angular Compiler requires TypeScript >=2.7.2 and <2.8.0 but 2.9.2 was found instead.It seems like I need to install the peer dependency for Angular compiler on my own. Could you please guide me on how to do this, or point me to some online resources? Thanksvladimiry commentedon Jul 3, 2018
@zuozhiw I don't use CLI, but use compiler directly in Webpack config. Based on the information you provided it looks like
angularCompilerOptions.disableTypeScriptVersionCheckoption didn't take an affect. I'd suggest to double check that you changed a righttsconfig.jsonfile. You can also debug it (at least usingconsole.logapproach), see related code line in my previous comment.albyrock87 commentedon Jul 6, 2018
@zuozhiw That option goes into tsconfig.app.json .. The "angularCompilerOptions" section is already there!
gkalpak commentedon Jul 26, 2018
I am closing this, since it seems to be complete. (@IgorMinar, reopen if not.)
There is a separate issue for tracking problems with TS 2.9: #25141
angular-automatic-lock-bot commentedon Sep 13, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.