Skip to content

bug(form): NgForm should not use camelCase in element selector #23678

Closed

Description

@trotyl

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:

Current behavior

<ngForm>
  <p>Some Input:</p>
  <input name="myModel" [(ngModel)]="myModel">
</ngForm>

Expected behavior

<ng-form>
  <p>Some Input:</p>
  <input name="myModel" [(ngModel)]="myModel">
</ng-form>

Minimal reproduction of the problem with instructions

https://stackblitz.com/edit/angular-ejraew?file=app%2Fapp.component.html

More directly:

selector: 'form:not([ngNoForm]):not([formGroup]),ngForm,[ngForm]',

What is the motivation / use case for changing the behavior?

It completely break the design consistency.
Also using (non-native) element selector is useful for nested forms as in AngularJS, should not be removed.

Actually just a mistake in #5765

Environment


Angular version: 2.0.0-alpha.52 ~ 6.0.0-rc.6


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

Activity

  1. changed the title [-]bug(form): NgForm should not use camelCase in element selecter[/-] [+]bug(form): NgForm should not use camelCase in element selector[/+] on May 3, 2018
  2. IgorMinar commented on May 3, 2018

    @IgorMinar
    Contributor

    ouch. I'm surprised we haven't noticed this before. you are right, we should fix this by deprecating the old selector and introducing the correct one + figuring out the migration path.

  3. added this to the needsTriage milestone on May 3, 2018
  4. modified the milestones: needsTriage, Backlog on May 3, 2018
  5. angular-automatic-lock-bot commented on Sep 13, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  6. locked and limited conversation to collaborators on Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions