Skip to content

Performance regression for tables that use shadow dom emulation #2298

Closed

Description

@tbosch

Large tables with e.g. 200 rows and 20 columns are really slow due to calling LightDom._collectAllContentTags (see https://github.com/angular/angular/blob/master/modules/angular2/src/render/dom/shadow_dom/light_dom.ts#L54) for every view that is added to a ViewContainer, resulting into a O^2 runtime.

Activity

  1. tbosch commented on Jun 13, 2015

    @tbosch
    ContributorAuthor

    This will be solved by #2529

  2. added this to the alpha-28 milestone on Jun 15, 2015
  3. self-assigned this
    on Jun 15, 2015
  4. modified the milestones: alpha-29, alpha-28 on Jun 17, 2015
  5. modified the milestones: alpha-30, alpha-29 on Jul 1, 2015
  6. modified the milestone: alpha-31 on Jul 1, 2015
  7. modified the milestones: alpha-31, alpha-32 on Jul 11, 2015
  8. tbosch commented on Jul 16, 2015

    @tbosch
    ContributorAuthor

    As #2529 landed in master, content projection is done during compilation, i.e. there is no performance penalty of using in during runtime.

  9. angular-automatic-lock-bot commented on Sep 6, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  10. locked and limited conversation to collaborators on Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions