Skip to content

google3 CI check seems to consider only the last commit and not the PR diff #22871

Closed

Description

@IgorMinar

While working on the rxjs v6 update PR #22573 I noticed that the g3 CI check suddenly claimed that the PR had no impact on g3 (it had). This check was working just fine until I pushed a last commit to the branch that had no impact on g3 - that makes me suspect that the check operates only on the last commit and not the diff between master and the PR HEAD.

Screenshot:

screen shot 2018-03-19 at 9 09 05 pm

Activity

  1. added this to the needsTriage milestone on Mar 20, 2018
  2. jelbourn commented on Oct 16, 2020

    @jelbourn
    Contributor

    Closing since this seems to be obsolete (Andrew Scott says it definitely checks the whole PR)

  3. angular-automatic-lock-bot commented on Nov 16, 2020

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  4. locked and limited conversation to collaborators on Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions