no tests for disableTypeScriptVersionCheck angularCompilerOptions flag #22699

Activity

1. ngbot

   added this to the needsTriage milestone on Mar 10, 2018
2. IgorMinar

   added

   type: bug/fix

   area: coreIssues related to the framework runtimeIssues related to the framework runtime

   on Mar 10, 2018
3. IgorMinar

   added a commit that references this issue on Mar 10, 2018

   fix(compiler-cli): disableTypeScriptVersionCheck should be applied ev…

   ...

   7db9649
4. kara

   added a commit that references this issue on Mar 12, 2018

   fix(compiler-cli): disableTypeScriptVersionCheck should be applied ev…

   ...

   3f70aba
5. mhevery

   added

   freq1: low

   severity3: broken

   on Mar 29, 2018
6. ngbot

   modified the milestones: needsTriage, Backlog on Mar 29, 2018
7. benbraou commented on Mar 30, 2018

   

   benbraou

   on Mar 30, 2018

   Contributor

   More actions

   @IgorMinar I believe this issue can be closed now.
   PR #22705 is merged in master now. It has added several tests, and among them tests for disableTypeScriptVersionCheck

   angular/packages/compiler-cli/test/transformers/program_spec.ts

   Lines 1052 to 1080 in a5f0939

   	describe('checkVersion', () => {
   	const MIN_TS_VERSION = '2.7.2';
   	const MAX_TS_VERSION = '2.8.0';
   	const versionError = (version: string) =>
   	`The Angular Compiler requires TypeScript >=${MIN_TS_VERSION} and <${MAX_TS_VERSION} but ${version} was found instead.`;
   	it('should not throw when a supported TypeScript version is used', () => {
   	expect(() => checkVersion('2.7.2', MIN_TS_VERSION, MAX_TS_VERSION, undefined)).not.toThrow();
   	expect(() => checkVersion('2.7.2', MIN_TS_VERSION, MAX_TS_VERSION, false)).not.toThrow();
   	expect(() => checkVersion('2.7.2', MIN_TS_VERSION, MAX_TS_VERSION, true)).not.toThrow();
   	});
   	it('should handle a TypeScript version < the minimum supported one', () => {
   	expect(() => checkVersion('2.4.1', MIN_TS_VERSION, MAX_TS_VERSION, undefined))
   	.toThrowError(versionError('2.4.1'));
   	expect(() => checkVersion('2.4.1', MIN_TS_VERSION, MAX_TS_VERSION, false))
   	.toThrowError(versionError('2.4.1'));
   	expect(() => checkVersion('2.4.1', MIN_TS_VERSION, MAX_TS_VERSION, true)).not.toThrow();
   	});
   	it('should handle a TypeScript version > the maximum supported one', () => {
   	expect(() => checkVersion('2.9.0', MIN_TS_VERSION, MAX_TS_VERSION, undefined))
   	.toThrowError(versionError('2.9.0'));
   	expect(() => checkVersion('2.9.0', MIN_TS_VERSION, MAX_TS_VERSION, false))
   	.toThrowError(versionError('2.9.0'));
   	expect(() => checkVersion('2.9.0', MIN_TS_VERSION, MAX_TS_VERSION, true)).not.toThrow();
   	});
   	});
8. pkozlowski-opensource

   added

   area: compilerIssues related to `ngc`, Angular's template compilerIssues related to `ngc`, Angular's template compiler

   and removed

   area: coreIssues related to the framework runtimeIssues related to the framework runtime

   on Mar 14, 2020
9. pkozlowski-opensource commented on Mar 14, 2020

   

   pkozlowski-opensource

   on Mar 14, 2020

   Member

   More actions

   Sounds like it was fixed: #22699 (comment)
10. pkozlowski-opensource

    closed this as completedon Mar 14, 2020
11. angular-automatic-lock-bot commented on Apr 14, 2020

    

    angular-automatic-lock-botBot

    on Apr 14, 2020

    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    _{This action has been performed automatically by a bot.}
12. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Apr 14, 2020