Skip to content

Compiler TypeScript version checking too simplistic #22593

Closed

Description

@chuckjaz

I'm submitting a...


[x] Bug report  

Current behavior

ngc will begin reporting errors correctly report an error for 2.7 but not 2.40 as it uses a string compare instead numeric compare for the version number.

if (ts.version < '2.4.2' || (ts.version >= '2.7.0' && !options.disableTypeScriptVersionCheck)) {

Expected behavior

TypeScript version detection is more resilient.

Activity

  1. added this to the needsTriage milestone on Mar 5, 2018
  2. modified the milestones: needsTriage, Backlog on Mar 5, 2018
  3. 8 remaining items

  4. added a commit that references this issue on Mar 30, 2018
    a5f0939
  5. angular-automatic-lock-bot commented on Sep 13, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  6. locked and limited conversation to collaborators on Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions