Repository navigation
Documentation error which says NgModule instead of BrowserModule #22158
Description
I'm submitting a...
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Feature request
[x] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
Current behavior
In Architecture Overview --> Angular Libraries
as in the below screen print it says "You also import NgModules from Angular libraries using JavaScript import statements:" which is in contradiction with the example shown in the code
Expected behavior
The description should have been "You also import BroserModul from Angular libraries using JavaScript import statements:" to inline with the code example given
Minimal reproduction of the problem with instructions
What is the motivation / use case for changing the behavior?
Environment
Angular version: X.Y.Z
Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
For Tooling issues:
- Node version: XX
- Platform:
Others:
Activity
trotyl commentedon Feb 12, 2018
Please note the
s(plural),BrowserModuleis only an example used, your app may import several different others NgModules as well, nothing wrong with that.Would you suggest something like:
shrivatsahosabettu commentedon Feb 12, 2018
Yes, that would be lot better.. Thanks for your comments.
jenniferfell commentedon Feb 15, 2018
Thank you for your feedback. We've done some work on the Architecture doc. We've expanded the information about NgModules in #21569. Does this sufficiently address this potential point of confusion?
jenniferfell commentedon May 25, 2018
Rechecked against v6. Keeping open.
@trotyl recommendation would be a useful clarification to help differentiate between "You import NgModule" (a proper noun) and "you import any ngModule" (kind of thing, which is the intent here).
Recommendation copied here for convenience: "You also import NgModules (eg. BrowserModule) from Angular libraries using JavaScript import statements."
7 remaining items
docs: clarify wording in architecture overview (#24481)
docs: refactor pipe example to use the HttpClient (#22741)
angular-automatic-lock-bot commentedon Sep 13, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.