Can't catch the exception from ActivatedRoute.queryParams when using % in the URL - causes app to crash

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ X ] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

Using ActivatedRoute.queryParams with url the includes % it throws an exception that can't be catched anywhere and causing the app to crash.

Expected behavior

To be able to catch this kind of error and to be able to keep working with the app

Minimal reproduction of the problem with instructions

http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
go to : https://embed.plnkr.co/tUMGOtW39iMDYKHcv1hm/
then add layout=!@#$%^&*() so that the new URL will be
https://embed.plnkr.co/tUMGOtW39iMDYKHcv1hm/?layout=!@#$%^&*()

Error found :
URIError: URI malformed
at decodeURIComponent ()
at Ye (vendor.6b9be0480d04ab9c9c6c.js:6)
at tn.$$parse (vendor.6b9be0480d04ab9c9c6c.js:6)
at tn.$$parseLinkUrl (vendor.6b9be0480d04ab9c9c6c.js:6)
at an.$get (vendor.6b9be0480d04ab9c9c6c.js:6)
at Object.a [as invoke] (vendor.6b9be0480d04ab9c9c6c.js:6)
at vendor.6b9be0480d04ab9c9c6c.js:6
at r (vendor.6b9be0480d04ab9c9c6c.js:6)
at i (vendor.6b9be0480d04ab9c9c6c.js:6)
at Object.a [as invoke] (vendor.6b9be0480d04ab9c9c6c.js:6)

What is the motivation / use case for changing the behavior?

By fixing this issue adding % in the URL will not crush the application

Environment


Angular version: 4.0.0


Browser:
- [ X ] Chrome (desktop) version 63.0.3239.132
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

Still an issue / angular 5.2.3.

In angular.js the router parses the uri component in a try/catch, thus ignoring invalid parts of the URL.

angular 5 doesn't try/catch. If decodeURIComponent throws (just like decodeURIComponent('%') does), then the app stops functioning.

I'm working on the solution and will submit the PR in near future.

fix(router): add ability to recover from malformed url

Still an issue / angular 6.0.0

fix(router): add ability to recover from malformed url (#23283)

docs: refactor pipe example to use the HttpClient (#22741)

Still an issue for me, here is the workaround:

import { UrlTree ,DefaultUrlSerializer, UrlSerializer } from '@angular/router';

export class cleanUrlSerializer extends DefaultUrlSerializer {
public parse(url: string): UrlTree {
  function cleanUrl(url) {
      return unescape(url);
  }
 
  return super.parse(cleanUrl(url));
  }
}

Add provider:

{
  provide: UrlSerializer,
  useClass: cleanUrlSerializer
}

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

Navigation Menu

Repository navigation

Can't catch the exception from ActivatedRoute.queryParams when using % in the URL - causes app to crash #21468

I'm submitting a...

Current behavior

Expected behavior

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Can't catch the exception from ActivatedRoute.queryParams when using % in the URL - causes app to crash #21468

Description

I'm submitting a...

Current behavior

Expected behavior

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment

Activity

sod commented on Feb 8, 2018

skryvets commented on Apr 7, 2018

feynmanloo commented on Jun 23, 2018

muriloqr commented on Apr 9, 2019

angular-automatic-lock-bot commented on Sep 14, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions