Repository navigation
Angular LS doesn't work with node.js 9 #21420
Description
I am working on Angular LS integration in WebStorm.
I have noticed that the integration doesn't work with node.js 9 because of the code
in node_modules/@angular/language-service/bundles/language-service.umd.js:8
var $reflect = {defineMetadata: function() {}, getOwnMetadata: function(){}};
((typeof global !== 'undefined' && global)||{})['Reflect'] = $reflect;
Source of the error: https://github.com/angular/angular/blob/master/packages/language-service/rollup.config.js#L49
Node.js throws the exception in this line https://github.com/nodejs/node/blob/master/lib/internal/process/next_tick.js#L63:
Reflect.apply(callback, undefined, tock.args);
error: Reflect.apply(callback, undefined, tock.args);
TypeError: Reflect.apply is not a function
error: TypeError: Reflect.apply is not a function
at process._tickCallback (internal/process/next_tick.js:152:19)
Reacted by Michael Bromley, Eric ZHANG, Hu Zheng, Alexander, zaalbarxx, Poul Kruijt, Herbert Poul, Alexander Turtsevich, Nadav Sinai, Asiel Leal Celdeiro and 8 more
Activity
kyliau commentedon Jan 10, 2018
Angular does not support Node 9 yet, but we will keep this in mind when upgrading.
https://github.com/angular/angular/blob/master/package.json#L11
mhegazy commentedon May 7, 2018
@chuckjaz any plans on fixing this issue? we are seeing it on VS as well..
brian428 commentedon May 23, 2018
This seems rather pressing, especially since Node is now up to 10.x.
fix(language-service): do not overwrite native `Reflect`
gkalpak commentedon Jun 4, 2018
I created #24299, but I am not sure how to test it (I couldn't reproduce the issue 😕).
anstarovoyt commentedon Jun 4, 2018
@gkalpak I have tested the changes it works fine!
1 remaining item
anstarovoyt commentedon Jul 3, 2018
@chuckjaz any updates?
prigara commentedon Jul 6, 2018
We've implemented a workaround in WebStorm, but we are really hoping to see the PR with the fix merged soon.
fix(language-service): do not overwrite native `Reflect` (#24299)
docs: refactor pipe example to use the HttpClient (#22741)
angular-automatic-lock-bot commentedon Sep 14, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.