Repository navigation
Expression converter typo #21233
Description
I'm submitting a...
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
Current behavior
There is a typo in expression_converter.ts
link
// For literal values of null, undefined, true, or false allow type inteference
// to infer the type.
const type =
ast.value === null || ast.value === undefined || ast.value === true || ast.value === true ?
o.INFERRED_TYPE :
undefined;
ast.value === true || ast.value === true
Expected behavior
ast.value === true || ast.value === false
Minimal reproduction of the problem with instructions
What is the motivation / use case for changing the behavior?
Just a typo
Environment
Any
Angular version: 5.1.2
Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
For Tooling issues:
- Node version: XX
- Platform:
Others:
Reacted by Sarun Intaralawan
Activity
bvdmitri commentedon Jan 3, 2018
As I can see the last commit was made by @chuckjaz. Can you review this line of code?
sarunint commentedon Jan 3, 2018
I believe it is. It's part of #20972
3 remaining items
fix(compiler): Expression converter typo
jelbourn commentedon Apr 6, 2021
Conversation on #37361 indicates that this might be dead code anyway. Since this is VE only, it's not really worth the effort to fix.
angular-automatic-lock-bot commentedon May 7, 2021
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.