AIO(docs) Routing & Navigation section missing CrisisCenterModule.ts #21174

Activity

1. IgorMinar

   added

   comp: docs

   on Dec 27, 2017
2. kapunahelewong

   added

   freq3: high

   severity1: confusing

   effort1: hours

   on Jan 2, 2018
3. hartraft commented on Jan 5, 2018

   

   hartraft

   on Jan 5, 2018

   ContributorAuthor

   More actions

   Thanks for taking a look at this. Just to add a bit more detail on the "Routing and Navigation" docs, I also saw that in Milestone 1 and Milestone 2, all components have inline templates in the examples (for src/app/app.component.ts, src/app/hero-list.component.ts etc.).

   However by the time you get to Milestone 3, the plunker and zip mentioned have components using the templateUrl.

   This example recreates the heroes feature in the "Services" episode of the Tour of Heroes tutorial, and you'll be copying much of the code from the Tour of Heroes: Services example code / download example.

   and

   Add heroes functionality

   Follow these steps:

   • Create the src/app/heroes folder; you'll be adding files implementing hero management there.

   • Delete the placeholder hero-list.component.ts that's in the app folder.

   • Create a new hero-list.component.ts under src/app/heroes.

   • Copy into it the contents of the app.component.ts from the "Services" tutorial / download example.

   • Make a few minor but necessary changes:

     • Delete the selector (routed components don't need them).
     • Delete the <h1>.
     • Relabel the <h2> to <h2>HEROES</h2>.
     • Delete the <hero-detail> at the bottom of the template.
     • Rename the AppComponent class to HeroListComponent.

   This causes two issues. First the plunker and zip are inconsistent with the rest of the documentation in the "Routing & Navigation" section.

   Secondly, the step "Make a few minor but necessary changes:" wouldn't make sense as there is no mention of <h1> and other elements (as the linked examples only include the templateUrl line).

   Sure we can do a translation in our heads but the documentation is incorrect as it stands. Perhaps it's a regression from changing the documentation examples. Do you want me to create a new issue for this instead?
4. ngbot

   added this to the needsTriage milestone on Feb 26, 2018
5. jenniferfell

   added

   area: router

   featureLabel used to distinguish feature request from other issuesLabel used to distinguish feature request from other issues

   subtype: docs-clarification

   on Jun 4, 2018
6. ngbot

   modified the milestones: needsTriage, Backlog on Jun 4, 2018
7. jenniferfell

   assigned

   brandonroberts

   on Jun 4, 2018
8. brandonroberts

   added

   state: has PR

   on Jun 26, 2018
9. brandonroberts commented on Sep 26, 2018

   

   brandonroberts

   on Sep 26, 2018

   Contributor

   More actions

   Fixed via #20023
10. brandonroberts

    closed this as completedon Sep 26, 2018
11. angular-automatic-lock-bot commented on Sep 14, 2019

    

    angular-automatic-lock-botBot

    on Sep 14, 2019

    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    _{This action has been performed automatically by a bot.}
12. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Sep 14, 2019