Skip to content

Bundled metadata does not reflect metadata lowering. #21082

Closed

Description

@chuckjaz

I'm submitting a...


[x] Bug report  

Current behavior

The metadata that is bundled with a FSEM is does not reflect rewritings performed by the compiler.

Expected behavior

The rewritings are taken into account in the metadata.

Minimal reproduction of the problem with instructions

From: https://github.com/dherges/ng-packagr/issues/382

git clone git@github.com:darkbasic/ngx-selectable-list.git
git checkout packagr
npm install
npm run packagr

Note that the new expression the the metadata for SelectableListModule which not present in src/app/selectable-list/directive/selectable-list/selectable-list.directive.metadata.json when compiled with ngc -p ./src/tsconfig.app.json.

What is the motivation / use case for changing the behavior?

The bundled version should apply rewritings.

Activity

  1. added this to the Backlog milestone on Jan 23, 2018
  2. dherges commented on Jan 25, 2018

    @dherges
    Contributor

    Here is another issue description:

    In the repro at https://github.com/georgiee/ng-packagr-foos, the bundled metadata json (scoped-some-name.metadata.json) has no metadata for FooModule and FooComponent. But, these two are exported by the FESM bundles ((esm5|esm2015)/scoped-some-name.js).

    Is that the same issue?

  3. modified the milestones: Backlog, needsTriage on Feb 26, 2018
  4. added
    area: compilerIssues related to `ngc`, Angular's template compiler
    and removed
    area: coreIssues related to the framework runtime
    on Mar 12, 2020
  5. alxhub commented on May 28, 2020

    @alxhub
    Member

    This is a longstanding and well known issue with View Engine's metadata bundler, and is systemic and non-trivial to fix. The good news is that Angular Ivy does not use the metadata system at all, and therefore this bug is rapidly becoming obsolete.

  6. added
    P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
    P5The team acknowledges the request but does not plan to address it, it remains open for discussion
    and removed
    P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
    on Oct 1, 2020
  7. JoostK commented on May 14, 2021

    @JoostK
    Member

    With v12 now allowing libraries to be compiled with the Ivy compiler, this issue has been resolved.

  8. angular-automatic-lock-bot commented on Jun 14, 2021

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  9. locked and limited conversation to collaborators on Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P5The team acknowledges the request but does not plan to address it, it remains open for discussionarea: compilerIssues related to `ngc`, Angular's template compilerfreq2: mediumstate: confirmedtype: bug/fix

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions