Skip to content

<my-app> in angular documentation #20235

Closed

Description

@pasha-bolokhov-cs

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[X] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

In some places you write my-app for the root selector, while in others you use app-root. This even happens on the same page, in particular at https://angular.io/guide/displaying-data
This is clearly a copying error
I suggest you do a search for other examples of this, in particular the Tour of Heroes

Expected behavior

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment


Angular version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

Activity

  1. trotyl commented on Nov 7, 2017

    @trotyl
    Contributor

    Duplicate of #19778

  2. kapunahelewong commented on Nov 9, 2017

    @kapunahelewong
    Contributor

    @pasha-bolokhov-cs Thanks for bringing this up. We're in the middle of changing these selectors per the PR @trotyl mentioned. It's just because my-app is leftover from pre-CLI documentation.

  3. pasha-bolokhov-cs commented on Nov 10, 2017

    @pasha-bolokhov-cs
    Author
  4. added this to the Backlog milestone on Jan 23, 2018
  5. modified the milestones: Backlog, needsTriage on Feb 26, 2018
  6. jenniferfell commented on Apr 25, 2018

    @jenniferfell
    Contributor

    Quick update. displaying-data appears to have been updated to app-root. lifecycle-hooks still uses my-child.

    Search needs to be done on the source, not on the angular.io/docs site to correctly locate any remaining instances.

  7. added
    P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
    and removed on Oct 1, 2020
  8. added a commit that references this issue on May 24, 2021
    51e6799
  9. added a commit that references this issue on May 25, 2021
    70b1bda
  10. added a commit that references this issue on May 28, 2021
    44fcb5b
  11. added a commit that references this issue on Jun 4, 2021
    fae0869
  12. angular-automatic-lock-bot commented on Jun 25, 2021

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  13. locked and limited conversation to collaborators on Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentfreq3: highstate: has PRtype: bug/fix

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions