You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Feature request
[X] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
Current behavior
In some places you write my-app for the root selector, while in others you use app-root. This even happens on the same page, in particular at https://angular.io/guide/displaying-data
This is clearly a copying error
I suggest you do a search for other examples of this, in particular the Tour of Heroes
Expected behavior
Minimal reproduction of the problem with instructions
What is the motivation / use case for changing the behavior?
Environment
Angular version: X.Y.Z
Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
For Tooling issues:
- Node version: XX
- Platform:
Others:
@pasha-bolokhov-cs Thanks for bringing this up. We're in the middle of changing these selectors per the PR @trotyl mentioned. It's just because my-app is leftover from pre-CLI documentation.
Activity
trotyl commentedon Nov 7, 2017
Duplicate of #19778
kapunahelewong commentedon Nov 9, 2017
@pasha-bolokhov-cs Thanks for bringing this up. We're in the middle of changing these selectors per the PR @trotyl mentioned. It's just because
my-appis leftover from pre-CLI documentation.pasha-bolokhov-cs commentedon Nov 10, 2017
jenniferfell commentedon Apr 25, 2018
Quick update. displaying-data appears to have been updated to app-root. lifecycle-hooks still uses my-child.
Search needs to be done on the source, not on the angular.io/docs site to correctly locate any remaining instances.
docs: convert the last `my-app` components to `app-root`
docs: convert the last `my-app` components to `app-root` (#42256)
docs: convert the last `my-app` components to `app-root` (angular#42256)
docs: convert the last `my-app` components to `app-root` (angular#42256)
angular-automatic-lock-bot commentedon Jun 25, 2021
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.