Repository navigation
Enable a reactive form using the FormControlDirective #20008
Description
I'm submitting a...
[ ] Regression (a behavior that used to work and stopped working in a new release)
[] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
Current behavior
Currently the FormControlDirective can't handle disabled property change from true to false.
Expected behavior
The FormControlDirective will update the control disabled property from true to false.
Minimal reproduction of the problem with instructions
https://plnkr.co/edit/hIg6qdPcwqykc1K6jRUd?p=preview
- Click on the button.
- The FormControlDirective will update the control disabled property from false to true.
- Click it button again.
- The FormControlDirective will NOT update the control disabled property from true to false.
What is the motivation / use case for changing the behavior?
I would like to be able to use the FormControlDirective to set the disabled property of a control from true to false.
Environment
Angular version: 4.4.6
Browser:
- [x] Chrome (desktop) 62.0.3202.75 (Official Build)
- [x] IE version 11.15.16299.0
- [x] Microsoft Edge 41.16299.15.0
Activity
trotyl commentedon Oct 30, 2017
Not related to
NgFor, currentlyFormControlDirectivewon't respectdisabledproperty change fromtruetofalse, since 2b313e4#diff-cae4150234e5b06ff9cd24d7f7d6f294 only handles the condition fromfalsetotrueforFormControlDirective.The problem can be identified easily in code: form_control_directive.ts#L91-L93
[-]Can't enable a reactive form input in a trackedBy ngFor.[/-][+]Can't enable a reactive form using FormControlDirective[/+][-]Can't enable a reactive form using FormControlDirective[/-][+]Enable a reactive form using the FormControlDirective[/+]sgkazakov commentedon Oct 30, 2017
@trotyl Thank you. I've updated the issue and the plunker.
trotyl commentedon Nov 16, 2017
Found it was duplicate of #17806.
dzonatan commentedon Nov 23, 2017
The fix is hanging in #18575 ... don't know how to get attention there.
kara commentedon Jan 23, 2018
Looks like a duplicate
angular-automatic-lock-bot commentedon Sep 13, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.